-
Notifications
You must be signed in to change notification settings - Fork 13.6k
fix issue 144074, having so many same diagnostics makes it hard to re… #144818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
This comment has been minimized.
This comment has been minimized.
You should run |
…cognize the root cause
5124e06
to
080e25b
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
@@ -403,14 +403,14 @@ impl<'a, 'tcx> FnCtxt<'a, 'tcx> { | |||
// that are not closures, then we type-check the closures. This is so | |||
// that we have more information about the types of arguments when we | |||
// type-check the functions. This isn't really the right way to do this. | |||
self.select_obligations_where_possible(|_| {}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this new call to select for? It may affect inference and also performance 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this new call to select for? It may affect inference and also performance 🤔
sorry, commit the debug code, will be fix in next pr.
@bors2 try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
fix issue 144074, having so many same diagnostics makes it hard to re…
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (bd230c7): comparison URL. Overall result: ❌ regressions - please read the text belowBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 469.09s -> 468.987s (-0.02%) |
fix issue #144074
use
LocalDefId
andObligationCauseCodeHandle
to skip duplicateObligationCause
.