Skip to content

Conversation

Kivooeo
Copy link
Member

@Kivooeo Kivooeo commented Aug 4, 2025

This was little bit discussed here #t-libs > `begin_panic` renaming @ 💬, so I guess this is fine name

Also as far as I can say it's safe to rename because of lang item, correct me here if I'm wrong

Part of #116005

@rustbot
Copy link
Collaborator

rustbot commented Aug 4, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 4, 2025

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

Some changes occurred to constck

cc @fee1-dead

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@rust-log-analyzer

This comment has been minimized.

@Kivooeo Kivooeo force-pushed the more-creative-name-for-begin-panic branch from 1fc546b to 8d38e92 Compare August 4, 2025 14:16
@rust-log-analyzer

This comment has been minimized.

@Kivooeo Kivooeo force-pushed the more-creative-name-for-begin-panic branch from 8d38e92 to 5d10eb5 Compare August 4, 2025 16:39
@rustbot rustbot added the A-rustc-dev-guide Area: rustc-dev-guide label Aug 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 4, 2025

rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead.

cc @rust-lang/rust-analyzer

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang

@Kivooeo
Copy link
Member Author

Kivooeo commented Aug 4, 2025

According to message above would it be reasonable to move rust-analyzer changes into it's repo? or it's fine like this

@rust-log-analyzer

This comment has been minimized.

@Kivooeo Kivooeo force-pushed the more-creative-name-for-begin-panic branch from 5d10eb5 to 98d2ad4 Compare August 4, 2025 16:46
@Kivooeo Kivooeo force-pushed the more-creative-name-for-begin-panic branch from 98d2ad4 to 22e6d2b Compare August 4, 2025 16:49
@rustbot rustbot added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Aug 4, 2025
@@ -3,16 +3,16 @@
//! This attribute to tell the compiler about semi built-in std library
//! features, such as Fn family of traits.
use hir_expand::name::Name;
use intern::{Symbol, sym};
use intern::{sym, Symbol};
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we're reformatting rust-analyzer code? That probably should not be made in rust-lang/rust, and instead left for upstream PR(s). Making the necessary 1-line change here seems reasonable though.

Copy link
Member Author

@Kivooeo Kivooeo Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I've asked about it above, thanks for an answer confirming it, but I will take some actions after we settle on naming, because currently according to a zullip topic we don't have consensus

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants