Skip to content

Dont print arg span in MIR dump for tail call #144920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Dont print arg span in MIR dump for tail call #144920

wants to merge 1 commit into from
+8 −8

Conversation

compiler-errors
Copy link
Member

r? WaffleLapkin

This makes the MIR dump for tail call terminators consistent w/ regular calls.

@rustbot
Copy link
Collaborator

rustbot commented Aug 4, 2025

WaffleLapkin is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 4, 2025
lqd
lqd approved these changes Aug 4, 2025
View reviewed changes
Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm if you don't need waffle's r+

@compiler-errors
Copy link
Member Author

nah, i doubt waffle would have an issue with this impl either

@bors r=lqd rollup

@bors
Copy link
Collaborator

bors commented Aug 4, 2025

📌 Commit 878acaa has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 4, 2025
samueltardieu added a commit to samueltardieu/rust that referenced this pull request Aug 4, 2025
@samueltardieu
Rollup merge of rust-lang#144920 - compiler-errors:span-arg, r=lqd
fb1198d 
Dont print arg span in MIR dump for tail call

r? WaffleLapkin

This makes the MIR dump for tail call terminators consistent w/ regular calls.
@samueltardieu samueltardieu mentioned this pull request Aug 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqd lqd lqd approved these changes

Assignees

@WaffleLapkin WaffleLapkin

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @rustbot @bors @lqd @WaffleLapkin