Allocate arguments from topmost frame into temporary storage before popping stack frame in init_fn_tail_call
#144933
+64
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rustbot
added
S-waiting-on-review
Kivooeo
reviewed
Aug 5, 2025
Comment on lines
+210
to
+217
| match self.value { | ||
| LocalValue::Dead => false, | ||
| LocalValue::Live(val) => match val { | ||
| Operand::Immediate(_) => false, | ||
| Operand::Indirect(_) => true, | ||
| }, | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| match self.value { | |
| LocalValue::Dead => false, | |
| LocalValue::Live(val) => match val { | |
| Operand::Immediate(_) => false, | |
| Operand::Indirect(_) => true, | |
| }, | |
| } | |
| } | |
| matches!(self.value, LocalValue::Live(Operand::Indirect(_))) |
I feel like it can be rewritten like this?
There was a problem hiding this comment.
I kinda prefer it to be exhaustive
compiler-errors
force-pushed
the
temp-local
branch
from
be61cdf to
20fc35f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing a tail call, we pop the topmost frame and then push a new frame to replace it. If we have an argument that is being passed indirectly from an mplace of a local from that old stack frame, then it will be invalidated before we can copy them into the locals of the new stack frame.
THis PR detects arguments that are being indirectly via pointers which point into the allocations of the topmost stack frame's locals. If we find an argument, we copy it into new temporary memory for constructing the new stack frame, and then we deallocate that old memory.
Not totally sure who should review this, since I'm not totally sure if I'm using CTFE correctly 😎 Specifically I don't know if I am implementing the right logic for "does this argument come from an allocation that corresponds to a local in the top stack frame".
r? @WaffleLapkin @RalfJung @oli-obk
Fix #144820