Skip to content

rustc_public: import requried extern crates in run_driver! #144967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

makai410
Copy link
Contributor

@makai410 makai410 commented Aug 5, 2025

It's unfair to put users to do this work, since they don't know what the code would be after macro expansion and what crates should be imported if they don't take a look at the source code.

However, unfortunately, they have to enable rustc_private themselves for now because run_driver! could occur as an expression, which would trigger the stmt_expr_attributes if we enable rustc_private in the macro. I think this would be fixed after we have a stable driver.

@rustbot
Copy link
Collaborator

rustbot commented Aug 5, 2025

r? @celinval

rustbot has assigned @celinval.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 5, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 5, 2025

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants