-
Notifications
You must be signed in to change notification settings - Fork 13.6k
rustdoc: fix caching of intra-doc links on reexports #144970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
rustdoc: fix caching of intra-doc links on reexports #144970
Conversation
rustbot has assigned @GuillaumeGomez. Use |
This comment has been minimized.
This comment has been minimized.
ec49112
to
34b358d
Compare
@bors2 try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
… r=<try> rustdoc: fix caching of intra-doc links on reexports
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (310f62e): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary 2.3%, secondary -4.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary -3.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 470.023s -> 468.852s (-0.25%) |
Seems like there is no perf change at all. |
previously two reexports of the same item would share a set of intra-doc links, which would cause problems if they had two different links with the same text. this was fixed by using the reexport defid as the key, if it is available.
fixes #144965