Skip to content

num: Rename isolate_most_least_significant_one functions #144971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

okaneco
Copy link
Contributor

@okaneco okaneco commented Aug 5, 2025

Tracking issue - #136909

libs-api has agreed to rename these unstable functions to isolate_highest_one/isolate_lowest_one
#136909 (comment)

isolate_most_significant_one -> isolate_highest_one
isolate_least_significant_one -> isolate_lowest_one

libs-api has agreed to rename these functions to
`isolate_highest_one`/`isolate_lowest_one`
@rustbot
Copy link
Collaborator

rustbot commented Aug 5, 2025

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 5, 2025
@joshtriplett
Copy link
Member

joshtriplett commented Aug 5, 2025

r=me once CI passes.

And thank you!

@jhpratt
Copy link
Member

jhpratt commented Aug 6, 2025

@bors r=joshtriplett rollup

@bors
Copy link
Collaborator

bors commented Aug 6, 2025

📌 Commit eee6f80 has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants