Skip to content

overhaul &mut suggestions in borrowck errors #145013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fee1-dead
Copy link
Member

@fee1-dead fee1-dead commented Aug 6, 2025

  • This refactors the logic so that it does not use fuzzy string matching for suggestions; it instead uses information directly from MIR.
  • If something comes from a custom Index impl for which the IndexMut trait does not apply, do not suggest adding mut after &.
  • Suggest get_mut with unwrap if error is fired on BTreeMap or HashMap.

Supersedes #144018 cc @xizheyin
Closes #143732

@rustbot
Copy link
Collaborator

rustbot commented Aug 6, 2025

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust suggests using IndexMut for maps, even though they don't implement the trait
3 participants