-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Consolidate panicking functions in slice/index.rs
#145137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kmeakin
wants to merge
1
commit into
rust-lang:master
Choose a base branch
from
Kmeakin:km/optimize-slice-index-panicking
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Consolidate panicking functions in slice/index.rs
#145137
Kmeakin
wants to merge
1
commit into
rust-lang:master
from
Kmeakin:km/optimize-slice-index-panicking
+166
−107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
6473bd2
to
2cc5be6
Compare
The Miri subtree was changed cc @rust-lang/miri |
2cc5be6
to
ea7033e
Compare
This comment has been minimized.
This comment has been minimized.
Consolidate all the panicking functions in `slice/index.rs` to use a single `slice_index_fail` function, similar to how it is done in `str/traits.rs`.
ea7033e
to
85e73f3
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
Thanks for the code. You could try |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate all the panicking functions in
slice/index.rs
to use a singleslice_index_fail
function, similar to how it is done instr/traits.rs
.Split off from #145024