Stabilize path_add_extension
#145209
Open
Stabilize path_add_extension
#145209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
4 tasks
|
☔ The latest upstream changes (presumably #145334) made this pull request unmergeable. Please resolve the merge conflicts. |
hanna-kruppe
force-pushed
the
path_add_extension
branch
from
7d7b202 to
52063ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FCP in tracking issue #127292 finished in January. There was more discussion since then, but libs-api decided to match
set_extensionby keeping the return type as-is and adding a panic for invalid extensions. The latter was implemented in #140163, so this feature should be ready for stabilization. But if anyone's unsure, another FCP could be done to confirm.Closes #127292