Skip to content

Stabilize path_add_extension #145209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Stabilize path_add_extension #145209

wants to merge 1 commit into from
+3 −13

Conversation

hanna-kruppe
Copy link
Contributor

@hanna-kruppe hanna-kruppe commented Aug 10, 2025 •
edited by rustbot
Loading

FCP in tracking issue #127292 finished in January. There was more discussion since then, but libs-api decided to match set_extension by keeping the return type as-is and adding a panic for invalid extensions. The latter was implemented in #140163, so this feature should be ready for stabilization. But if anyone's unsure, another FCP could be done to confirm.

Closes #127292

@rustbot
Copy link
Collaborator

rustbot commented Aug 10, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 10, 2025
@hanna-kruppe hanna-kruppe mentioned this pull request Aug 10, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tgross35 tgross35

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking Issue for PathBuf::add_extension and Path::with_added_extension
3 participants
@hanna-kruppe @rustbot @tgross35