Skip to content

Add regression test for former ICE involving malformed meta items containing interpolated tokens #145250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fmease
Copy link
Member

@fmease fmease commented Aug 11, 2025

Add regression test for #140612 from #140601 or rather #140859 that only added it to stable not master.
Supersedes #140584.

r? @jdonszelmann or anyone

…taining interpolated tokens

Co-authored-by: Jana Dönszelmann <jana@donsz.nl>
@rustbot
Copy link
Collaborator

rustbot commented Aug 11, 2025

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 11, 2025
@fmease
Copy link
Member Author

fmease commented Aug 11, 2025

(Let's better wait for CI to be green cuz I didn't run anything locally)

@jdonszelmann
Copy link
Contributor

Sounds good

@fmease fmease marked this pull request as draft August 11, 2025 14:19
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2025
@fmease
Copy link
Member Author

fmease commented Aug 11, 2025

Need to double check that it actually ICEs in the problematic version(s).

Edit: It does (ref: 1.87.0-beta.4).

@fmease fmease marked this pull request as ready for review August 11, 2025 14:22
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants