Skip to content

Document compiler and stdlib in stage1 in pr-check-2 CI job #145253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Aug 11, 2025

This restores the original behavior pre-#145011 (I thought that stage 2 makes more sense here, but it made the job ~30m slower, which is bad).

Let's see what will be the "new" duration, it should be ~55 minutes.

r? @jieyouxu

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 11, 2025
@jieyouxu
Copy link
Member

Thanks, you can r=me if it takes the expect amount of time.

@Kobzol Kobzol force-pushed the pr-check-2-doc-stage-1 branch from 1f3ca0a to 79a134a Compare August 11, 2025 15:39
@Kobzol
Copy link
Member Author

Kobzol commented Aug 11, 2025

... Right, CI uses the dist profile, which has doc-stage set to 2 by default. Let's try again with explicit stage 1..

@Kobzol
Copy link
Member Author

Kobzol commented Aug 11, 2025

Ok, good!

@bors r=jieyouxu rollup

@bors
Copy link
Collaborator

bors commented Aug 11, 2025

📌 Commit 79a134a has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2025
lolbinarycat added a commit to lolbinarycat/rustc-dev-guide that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants