Skip to content

ci: clean windows disk space in background #145311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcoieni
Copy link
Member

Speed up cleaning up disk space by launching the process in the background.
We wait for it to finish before running the build.

Context

The disk space cleanup was introduced in #144305

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 12, 2025
@marcoieni
Copy link
Member Author

@bors try jobs=msvc,mingw

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Aug 12, 2025
…=<try>

ci: clean windows disk space in background

try-job: *msvc*
try-job: *mingw*
@rust-bors
Copy link

rust-bors bot commented Aug 12, 2025

💔 Test for 8cf61b6 failed: CI. Failed jobs:

@rust-log-analyzer
Copy link
Collaborator

The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
tidy check
Checking tidy rustdoc_json...
No error code explanation was removed!
tidy: Skipping binary file check, read-only filesystem
##[error]tidy error: /checkout/src/ci/scripts/free-disk-space-windows-start.py:60: line longer than 100 chars
removing old virtual environment
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10' and 'venv'
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10' and 'virtualenv'
Requirement already satisfied: pip in ./build/venv/lib/python3.10/site-packages (25.1.1)
Collecting pip
---
    Uninstalling pip-25.1.1:
      Successfully uninstalled pip-25.1.1
Successfully installed pip-25.2
linting python files
/checkout/src/ci/scripts/free-disk-space-windows-start.py:1:1: EXE001 Shebang is present but file is not executable
/checkout/src/ci/scripts/free-disk-space-windows-wait.py:1:1: EXE001 Shebang is present but file is not executable
Found 2 errors.

python linting failed! Printing diff suggestions:
some tidy checks failed
tidy error: checks with external tool 'ruff' failed
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/rust-tidy /checkout /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo /checkout/obj/build 4 /node/bin/npm --extra-checks=py,cpp,js` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1636:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1239:29

Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:01:14
  local time: Tue Aug 12 16:21:40 UTC 2025
  network time: Tue, 12 Aug 2025 16:21:40 GMT
##[error]Process completed with exit code 1.
Post job cleanup.

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-msvc-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
  SCCACHE_BUCKET: rust-lang-ci-sccache2
  SCCACHE_REGION: us-west-1
  CACHE_DOMAIN: ci-caches.rust-lang.org
##[endgroup]
##[notice]Started free-disk-space cleanup in background (PID=7580); log: C:\a\_temp\free-disk-space.log; pidfile: C:\a\_temp\free-disk-space.pid
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: C:\Program Files\Git\bin\bash.EXE --noprofile --norc -e -o pipefail {0}
---
fmt: checked 6301 files
tidy check
Checking tidy rustdoc_json...
No error code explanation was removed!
tidy error: C:\a\rust\rust\src\ci\scripts\free-disk-space-windows-start.py:60: line longer than 100 chars
some tidy checks failed
Command `C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0-tools-bin\rust-tidy.exe C:\a\rust\rust C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage0\bin\cargo.exe C:\a\rust\rust\build 4 'C:\Program Files\nodejs\npm'` failed with exit code 1
Created at: src\bootstrap\src\core\build_steps\tool.rs:1636:23
Executed at: src\bootstrap\src\core\build_steps\test.rs:1239:29

Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:02:39
make: *** [Makefile:114: ci-msvc-ps1] Error 1
  local time: Tue Aug 12 16:28:23 CUT 2025
  network time: Tue, 12 Aug 2025 16:28:23 GMT
##[error]Process completed with exit code 2.
Post job cleanup.
[command]"C:\Program Files\Git\bin\git.exe" version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants