Skip to content

Conversation

rs-sac
Copy link
Contributor

@rs-sac rs-sac commented Aug 15, 2025

Tracking issue: #70530
FCP completed: #70530 (comment)
Closes: #70530

@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 15, 2025

The Miri subtree was changed

cc @rust-lang/miri

@rs-sac
Copy link
Contributor Author

rs-sac commented Aug 15, 2025

@rustbot r? the8472

@rustbot rustbot assigned the8472 and unassigned Mark-Simulacrum Aug 15, 2025
@bors
Copy link
Collaborator

bors commented Aug 27, 2025

☔ The latest upstream changes (presumably #145916) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot
Copy link
Collaborator

rustbot commented Aug 27, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rs-sac
Copy link
Contributor Author

rs-sac commented Aug 27, 2025

@the8472 I went back to stabilization only and rebased. Was there anything else necessary?

@the8472 the8472 added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 12, 2025
@the8472
Copy link
Member

the8472 commented Sep 12, 2025

already FCP'd, LGTM

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 12, 2025

📌 Commit f8a7f82 has been approved by the8472

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2025
bors added a commit that referenced this pull request Sep 13, 2025
Stabilize BTree{Map,Set}::extract_if

Tracking issue: #70530
FCP completed: #70530 (comment)
Closes: #70530
@bors
Copy link
Collaborator

bors commented Sep 13, 2025

⌛ Testing commit f8a7f82 with merge 5835d5f...

@bors
Copy link
Collaborator

bors commented Sep 13, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 13, 2025
@rs-sac
Copy link
Contributor Author

rs-sac commented Sep 13, 2025

@the8472 It appears that the i686-msvc-1 job inexplicably got stuck for over one hour.

@tgross35
Copy link
Contributor

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2025
bors added a commit that referenced this pull request Sep 13, 2025
Rollup of 5 pull requests

Successful merges:

 - #144498 (Add --print target-spec-json-schema)
 - #145471 (Stabilize BTree{Map,Set}::extract_if)
 - #145896 (Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#3 of Batch #2])
 - #146450 (bootstrap: rustdoc-js tests can now be filtered by js files)
 - #146456 (Fix panic and incorrectly suggested examples in `format_args` macro.)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5b37a1e into rust-lang:master Sep 13, 2025
10 of 11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 13, 2025
rust-timer added a commit that referenced this pull request Sep 13, 2025
Rollup merge of #145471 - rs-sac:extr, r=the8472

Stabilize BTree{Map,Set}::extract_if

Tracking issue: #70530
FCP completed: #70530 (comment)
Closes: #70530
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Sep 14, 2025
Rollup of 5 pull requests

Successful merges:

 - rust-lang/rust#144498 (Add --print target-spec-json-schema)
 - rust-lang/rust#145471 (Stabilize BTree{Map,Set}::extract_if)
 - rust-lang/rust#145896 (Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [rust-lang/rust#3 of Batch rust-lang/rust#2])
 - rust-lang/rust#146450 (bootstrap: rustdoc-js tests can now be filtered by js files)
 - rust-lang/rust#146456 (Fix panic and incorrectly suggested examples in `format_args` macro.)

r? `@ghost`
`@rustbot` modify labels: rollup
@rs-sac rs-sac deleted the extr branch September 15, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue for {BTreeMap,BTreeSet}::extract_if
6 participants