fix: incorrect error message for string literal suffixes #145602
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #144161
When a raw string literal has an invalid suffix (like
r#"test"#suffix
), the compiler was not reporting the appropriate error message "suffixes on string literals are invalid". This was particularly problematic when the suffix was immediately followed by another token, as inr#" \\ "#r"\\ "
.Changes
Modified
parse_expr_lit
incompiler/rustc_parse/src/parser/expr.rs
to validate literals usingLitKind::from_token_lit
and report errors appropriately.By doing so,
When modifying the lexer directly to detect invalid suffixes, the two problems mentioned above additionally occurred.
Also, modified it to consume the next token if it's a string literal after reporting a suffix error. This prevents the parser from generating the cascading error.