Skip to content

Uplift rustc_mir_transform::coverage::counters::union_find to rustc_data_structures. #145738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cjgillot
Copy link
Contributor

I was wondering if we had some union-find implementation in the compiler. We do. So put it where we can find it.

@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 22, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 22, 2025

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

Some changes occurred in coverage instrumentation.

cc @Zalathar

@Zalathar
Copy link
Contributor

I had another look through my implementation, and it does seem worth uplifting.

I feel tempted to write some more thorough unit tests, but that can just as easily be done after the uplift.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 22, 2025

📌 Commit 689171d has been approved by Zalathar

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2025
@lqd
Copy link
Member

lqd commented Aug 22, 2025

We do have ena, but the ergonomics aren’t that great for regular union-find (e.g. it creates the keys or something IIRC).

@Zalathar
Copy link
Contributor

Yeah, I found that the learning curve and amount of boilerplate required to use ena for basic union-find stuff is prohibitively high.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants