Fix attribute target checking for macro calls #145788
Open
+325
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-attributes
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
the
T-compiler
JonathanBrouwer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #145779
The system for target checking around macro calls is a little weird at the moment, I'll try to fix this in a better way in the near future but that is a bit more effort. But this PR fixes the bug, which is good enough for now.
The actual lint is still produced by the old target checking system, the new system tries to produce a lint (since
MacroCalls are now specified with theWarnpolicy in all the places where they previously also were), but this lint is ignored since there currently is no way to produce lints from the early attribute parsing staged. I'll try to get early lints fixed in the near future as well.r? @jdonszelmann