Skip to content

Handle unwinding fatal errors in codegen workers #145814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle unwinding fatal errors in codegen workers #145814

wants to merge 2 commits into from
+133 −151

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Aug 24, 2025

Also directly unwind on fatal errors at the point they are emitted inside the codegen backends.

Fixes the coordinator ICE of #132240, #135075 and #145800.

@rustbot
Copy link
Collaborator

rustbot commented Aug 24, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 24, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 24, 2025

Some changes occurred in compiler/rustc_codegen_ssa

cc @WaffleLapkin

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

@bjorn3 bjorn3 mentioned this pull request Aug 24, 2025
Open
@bjorn3
Copy link
Member Author

bjorn3 commented Aug 24, 2025

Fixes the coordinator ICE of #132240, #135075 and #145800.

Is that enough to close those issues or should they be kept open until underlying reason those object files are missing is known and fixed?

@bjorn3
Directly raise fatal errors inside the codegen backends
525c6a3 
As opposed to passing it around through Result.
@bjorn3 bjorn3 force-pushed the codegen_worker_fatal_error branch from e4813b8 to 525c6a3 Compare August 24, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjorn3 @rustbot @petrochenkov