Skip to content

Make macOS dist build configuration match where reasonable #145883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make macOS dist build configuration match where reasonable #145883

wants to merge 1 commit into from

Conversation

shepmaster
Copy link
Member

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Aug 26, 2025
@shepmaster
Copy link
Member Author

@bors2 try jobs=dist-aarch64-apple,dist-x86_64-apple

rust-bors bot added a commit that referenced this pull request Aug 26, 2025
@rust-bors
Auto merge of #145883 - shepmaster:unify-macos-ci, r=<try>
f69a3c9 
Make macOS dist build configuration match where reasonable

try-job: dist-aarch64-apple
try-job: dist-x86_64-apple
@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors
Copy link

rust-bors bot commented Aug 26, 2025

💥 Test timed out after 21600s

@madsmtm
Copy link
Contributor

madsmtm commented Sep 4, 2025

@bors2 try jobs=dist-aarch64-apple,dist-x86_64-apple

rust-bors bot added a commit that referenced this pull request Sep 4, 2025
@rust-bors
Auto merge of #145883 - shepmaster:unify-macos-ci, r=<try>
7c8d24f 
Make macOS dist build configuration match where reasonable

try-job: dist-aarch64-apple
try-job: dist-x86_64-apple
@rust-bors

This comment has been minimized.

Sign in to view
madsmtm
madsmtm approved these changes Sep 4, 2025
View reviewed changes
Copy link
Contributor

@madsmtm madsmtm left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, feel free to r=me if CI passes

View changes since this review

@rust-bors
Copy link

rust-bors bot commented Sep 4, 2025

💔 Test for 7c8d24f failed: CI

@shepmaster
Copy link
Member Author

The job was not acquired by Runner of type hosted even after multiple attempts
Internal server error. Correlation ID: f34999f5-df47-436b-aaf8-85b99070b650

🤷

@bors2 try jobs=dist-aarch64-apple,dist-x86_64-apple

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Sep 5, 2025
@rust-bors
Auto merge of #145883 - shepmaster:unify-macos-ci, r=<try>
bb65748 
Make macOS dist build configuration match where reasonable

try-job: dist-aarch64-apple
try-job: dist-x86_64-apple
@rust-bors
Copy link

rust-bors bot commented Sep 5, 2025

☀️ Try build successful (CI)
Build commit: bb65748 (bb65748540788cb5fc7be496dc50f9f01a6e73c1, parent: c559c4a741836c4ffa8e4f60cb9fe7e92af5298e)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsmtm madsmtm madsmtm approved these changes

Assignees

@madsmtm madsmtm

Labels
A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shepmaster @madsmtm @rustbot