compiler: Include span of too huge enum with -Cdebuginfo=2
#145967
+33
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have the ui test
tests/ui/limits/huge-enum.rs
to ensure we emit an error if we encounter too big enums. Before this fix, compiling the test with-Cdebuginfo=2
would not include the span of the instantiation site, because the error is then emitted from a different code path that does not include the span.Propagate the span to the error also in the debuginfo case, so the test passes regardless of debuginfo level. I'm sure we can propagate spans in more places, but let's start small.
Test failure without the fix
Here is what the failure looks like if you run the test without the fix:
as can be seen, the
span
used to be missing withdebuginfo=2
.See also
This is one small step towards resolving #61117.
cc #144499 which began running UI tests with
rust.debuginfo-level-tests=1
. This PR is part of preparing for increasing that to debuglevel 2.