Add bootstrap.toml option to control debug breaking on ICEs on windows #145976
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @clubby789 rustbot has assigned @clubby789. Use |
|
This PR modifies If appropriate, please update This PR modifies If appropriate, please update |
rustbot
added
S-waiting-on-review
beepster4096
force-pushed
the
configure_debugbreak
branch
from
e67380d to
507f6d2
Compare
clubby789
reviewed
Aug 29, 2025
| @@ -856,6 +856,9 @@ | |||
| # as libstd features, this option can also be used to configure features such as optimize_for_size. | |||
| #rust.std-features = ["panic_unwind"] | |||
|
|
|||
| # Trigger a breakpoint after internal compiler errors during bootstrap on windows | |||
There was a problem hiding this comment.
nit:
Suggested change
| # Trigger a breakpoint after internal compiler errors during bootstrap on windows | |
| # Trigger a `DebugBreak` after an internal compiler error during bootstrap on Windows |
LGTM otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rustc ICEs during bootstrap on Windows, it will call
DebugBreak. This is intended to trigger a Windows Error Reporting dialog that can launch a debugger. However on some setups (mine for one) this will just abort the process, hiding any ICEs on other threads as well. I also would not want to see this dialog even if it did work for me.This PR adds a new option to bootstrap.toml
rust.break-on-iceto configure this behavior. By default, it is enabled, matching the existing behavior.