Skip to content

Conversation

weihanglo
Copy link
Member

@weihanglo weihanglo commented Sep 3, 2025

12 commits in a6c58d43051d01d83f55a3e61ef5f5b2b0dd6bd9..761c4658d0079d607e6d33cf0c060e61a617cad3
2025-08-26 23:05:12 +0000 to 2025-09-04 01:25:01 +0000

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2025

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbot
Copy link
Collaborator

rustbot commented Sep 3, 2025

⚠️ Warning ⚠️

@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Sep 3, 2025

📌 Commit a07f679 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2025
bors added a commit that referenced this pull request Sep 3, 2025
Update cargo submodule

9 commits in a6c58d43051d01d83f55a3e61ef5f5b2b0dd6bd9..78a5531ed6608192b5f97eda64ba6e1f6a633eff
2025-08-26 23:05:12 +0000 to 2025-09-03 17:46:38 +0000
- fix(publish): Don't generate final artifacts (rust-lang/cargo#15910)
- chore: Address most typos (rust-lang/cargo#15911)
- chore(deps): update rust crate annotate-snippets to 0.12.1 (rust-lang/cargo#15909)
- test(script): Switch frontmatter tests to end-to-end (rust-lang/cargo#15899)
- chore: fix some typos and grammar (rust-lang/cargo#15905)
- Update dependencies (rust-lang/cargo#15904)
- feat: Don't stop at first error when emitting lints and warnings (rust-lang/cargo#15889)
- fix(cli): Show the bad manifest path (rust-lang/cargo#15896)
- chore(deps): update rust crate tracing-subscriber to v0.3.20 [security] (rust-lang/cargo#15898)

r? ghost
@bors
Copy link
Collaborator

bors commented Sep 3, 2025

⌛ Testing commit a07f679 with merge 2d3a72f...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Collaborator

bors commented Sep 3, 2025

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 3, 2025
github-merge-queue bot pushed a commit to rust-lang/cargo that referenced this pull request Sep 4, 2025
### What does this PR try to resolve?

We have downgraded this in #15851
We should also let renovate ignore it.

This also again downgrades libc to 0.2.174 again.

See
<rust-lang/rust#146176 (comment)>.
@weihanglo
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Sep 4, 2025

📌 Commit 94fd69a has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2025
@bors
Copy link
Collaborator

bors commented Sep 4, 2025

⌛ Testing commit 94fd69a with merge 79bdc62...

@bors
Copy link
Collaborator

bors commented Sep 4, 2025

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 79bdc62 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 4, 2025
@bors bors merged commit 79bdc62 into rust-lang:master Sep 4, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 4, 2025
Copy link
Contributor

github-actions bot commented Sep 4, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 033c0a4 (parent) -> 79bdc62 (this PR)

Test differences

Show 251 test diffs

Stage 2

  • build::rustc_wrapper_precedence: [missing] -> pass (J0)
  • build::rustc_wrapper_precendence: pass -> [missing] (J0)
  • script::basic_rs: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::cargo::basic_path: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::basic_rs: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::clean_output_with_edition: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::cmd_check_requires_nightly: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::cmd_check_requires_z_flag: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::cmd_pkgid_with_embedded: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::cmd_pkgid_with_embedded_no_lock_file: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::cmd_read_manifest_with_embedded: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::cmd_tree_with_embedded: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::cmd_verify_project_with_embedded: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::default_programmatic_verbosity: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::did_you_mean_command_stable: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::did_you_mean_file: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::disallow_explicit_bin: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::disallow_explicit_lib: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::disallow_explicit_test: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::ignore_surrounding_workspace: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::no_local_lockfile: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::requires_nightly: [missing] -> pass (J0)
  • script::cargo::script_as_dep: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::test_name_has_weird_chars: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::test_name_is_number: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::test_no_autobins: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::test_same_flags: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::cargo::test_unescaped_hyphen_arg: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::clean_output_with_edition: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::cmd_generate_lockfile_with_embedded: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::cmd_metadata_with_embedded: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::cmd_pkgid_with_embedded: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::cmd_pkgid_with_embedded_dep: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::cmd_pkgid_with_embedded_no_lock_file: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::cmd_read_manifest_with_embedded: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::cmd_update_with_embedded: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::cmd_verify_project_with_embedded: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::did_you_mean_file: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::did_you_mean_file_stable: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::disallow_explicit_example: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::disallow_explicit_package_autobenches: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::disallow_explicit_package_autobins: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::disallow_explicit_package_autolib: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::disallow_explicit_package_autotests: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::disallow_explicit_package_build: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::disallow_explicit_test: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::implicit_target_dir: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::non_existent_rs: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::requires_nightly: pass -> [missing] (J0)
  • script::rustc::dot_in_infostring_leading: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::rustc::dot_in_infostring_non_leading: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::rustc::escape: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::rustc::frontmatter_after_tokens: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::rustc::frontmatter_inner_hyphens_2: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::rustc::frontmatter_whitespace_3: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::rustc::frontmatter_whitespace_4: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::rustc::hyphen_in_infostring_leading: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::rustc::included_frontmatter: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::rustc::mismatch_2: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::rustc::multifrontmatter: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::rustc::proc_macro_observer: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::rustc::shebang: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::rustc::unclosed_2: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::rustc::unclosed_4: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::rustc::unclosed_5: [missing] -> ignore (-Zscript is unstable) (J0)
  • script::script_as_dep: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::test_line_numbering_preserved: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::test_name_has_weird_chars: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::test_no_autobins: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::test_path_dep: ignore (-Zscript is unstable) -> [missing] (J0)
  • script::warning_without_edition: ignore (-Zscript is unstable) -> [missing] (J0)
  • util::frontmatter::test::split_attribute: [missing] -> pass (J0)
  • util::frontmatter::test::split_dashes_in_body: [missing] -> pass (J0)
  • util::frontmatter::test::split_default: [missing] -> pass (J0)
  • util::frontmatter::test::split_dependencies: [missing] -> pass (J0)
  • util::frontmatter::test::split_infostring: [missing] -> pass (J0)
  • util::frontmatter::test::split_invalid_escaped: [missing] -> pass (J0)
  • util::frontmatter::test::split_leading_newlines: [missing] -> pass (J0)
  • util::frontmatter::test::split_mismatched_dashes: [missing] -> pass (J0)
  • util::frontmatter::test::split_missing_close: [missing] -> pass (J0)
  • util::frontmatter::test::split_too_few_dashes: [missing] -> pass (J0)
  • util::toml::embedded::test_expand::expand_default: pass -> [missing] (J0)
  • util::toml::embedded::test_expand::expand_dependencies: pass -> [missing] (J0)
  • util::toml::embedded::test_expand::rustc_dot_in_infostring_non_leading: pass -> [missing] (J0)
  • util::toml::embedded::test_expand::rustc_frontmatter_inner_hyphens_2: pass -> [missing] (J0)
  • util::toml::embedded::test_expand::rustc_frontmatter_whitespace_3: pass -> [missing] (J0)
  • util::toml::embedded::test_expand::rustc_frontmatter_whitespace_4: pass -> [missing] (J0)
  • util::toml::embedded::test_expand::rustc_hyphen_in_infostring_leading: pass -> [missing] (J0)
  • util::toml::embedded::test_expand::rustc_included_frontmatter: pass -> [missing] (J0)
  • util::toml::embedded::test_expand::rustc_shebang: pass -> [missing] (J0)
  • util::toml::embedded::test_expand::rustc_unclosed_1: pass -> [missing] (J0)
  • util::toml::embedded::test_expand::rustc_unclosed_5: pass -> [missing] (J0)
  • util::toml::embedded::test_expand::split_attribute: pass -> [missing] (J0)
  • util::toml::embedded::test_expand::split_crlf: pass -> [missing] (J0)
  • util::toml::embedded::test_expand::split_indent: pass -> [missing] (J0)
  • util::toml::embedded::test_expand::split_invalid_escaped: pass -> [missing] (J0)
  • registry::unaccessible_registry_cache_still_works: ignore (On Windows setting file attributes is a bit complicated) -> [missing] (J1)
  • registry::unaccessible_registry_cache_still_works: pass -> [missing] (J2)
  • script::cargo::warn_when_plugin_masks_manifest_on_stable: [missing] -> ignore (-Zscript is unstable) (J2)
  • script::manifest_precedence_over_plugins: ignore (-Zscript is unstable) -> [missing] (J2)

(and 149 additional test diffs)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 79bdc627562db90599edcf16cb166a532919a0a8 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 4789.7s -> 6632.4s (38.5%)
  2. x86_64-gnu-llvm-20-3: 6574.4s -> 7423.5s (12.9%)
  3. aarch64-gnu-llvm-19-1: 3726.5s -> 3293.2s (-11.6%)
  4. dist-x86_64-apple: 8241.0s -> 7336.2s (-11.0%)
  5. i686-gnu-2: 6060.6s -> 5404.5s (-10.8%)
  6. dist-aarch64-msvc: 5465.1s -> 6039.6s (10.5%)
  7. x86_64-gnu-llvm-20-1: 3592.5s -> 3216.5s (-10.5%)
  8. aarch64-gnu-llvm-19-2: 2420.8s -> 2176.5s (-10.1%)
  9. i686-gnu-1: 8332.5s -> 7493.6s (-10.1%)
  10. aarch64-gnu-debug: 4210.7s -> 3814.9s (-9.4%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (79bdc62): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.3% [0.1%, 0.5%] 5
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary -4.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-4.9% [-9.4%, -1.9%] 3
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -4.9% [-9.4%, -1.9%] 3

Cycles

Results (secondary 3.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.5% [2.2%, 6.0%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 466.287s -> 466.814s (0.11%)
Artifact size: 388.39 MiB -> 387.87 MiB (-0.13%)

@weihanglo weihanglo deleted the update-cargo branch September 4, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants