Update cc-rs to 1.2.33, and switch rustc_codegen_ssa to use find-msvc-tools #146186
+23
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failed to set assignee to
|
rustbot
added
A-LLVM
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. Some changes occurred in compiler/rustc_codegen_ssa |
|
@bors try jobs=aarch64-msvc-1,aarch64-apple,test-various,dist-apple-various |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Sep 4, 2025
Update cc-rs to 1.2.33 try-job: aarch64-msvc-1 try-job: aarch64-apple try-job: test-various try-job: dist-apple-various
NobodyXu
reviewed
Sep 4, 2025
|
Let me know @dpaoliello if you want to try with |
rustbot
added
S-waiting-on-author
|
Reminder, once the PR becomes ready for a review, use |
This comment has been minimized.
This comment has been minimized.
dpaoliello
changed the title
|
I switched to @rustbot ready |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
rustbot
added
A-tidy
|
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. |
davidtwco
approved these changes
Sep 4, 2025
|
@bors r=davidtwco,jieyouxu |
bors
removed
the
S-waiting-on-review
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Sep 5, 2025
Update cc-rs to 1.2.33, and switch rustc_codegen_ssa to use find-msvc-tools For my purposes, contains fixes when compiling the Rust compiler for Arm64EC. Checked the commits since 1.2.16, and I don't see anything else that may affect Rust? `find-msvc-tools` was also factored out from `cc` to allow updating the use in `rustc_codegen_ssa` (finding the linker when running the Rust compiler) to be separate from the use in `rustc_llvm` (building LLVM as part of the Rust compiler).
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Sep 5, 2025
Update cc-rs to 1.2.33, and switch rustc_codegen_ssa to use find-msvc-tools For my purposes, contains fixes when compiling the Rust compiler for Arm64EC. Checked the commits since 1.2.16, and I don't see anything else that may affect Rust? `find-msvc-tools` was also factored out from `cc` to allow updating the use in `rustc_codegen_ssa` (finding the linker when running the Rust compiler) to be separate from the use in `rustc_llvm` (building LLVM as part of the Rust compiler).
tgross35
added a commit
to tgross35/rust
that referenced
this pull request
Sep 5, 2025
Update cc-rs to 1.2.33, and switch rustc_codegen_ssa to use find-msvc-tools For my purposes, contains fixes when compiling the Rust compiler for Arm64EC. Checked the commits since 1.2.16, and I don't see anything else that may affect Rust? `find-msvc-tools` was also factored out from `cc` to allow updating the use in `rustc_codegen_ssa` (finding the linker when running the Rust compiler) to be separate from the use in `rustc_llvm` (building LLVM as part of the Rust compiler).
bors
added a commit
that referenced
this pull request
Sep 5, 2025
Rollup of 6 pull requests Successful merges: - #144342 (add exact bitshifts) - #145709 (Fix LoongArch C function ABI when passing/returning structs containing floats) - #146152 (Unify and deduplicate algebraic float tests) - #146186 (Update cc-rs to 1.2.33, and switch rustc_codegen_ssa to use find-msvc-tools) - #146207 (std: Implement WASIp2-specific stdio routines) - #146217 (fix ICE when suggesting `::new`) r? `@ghost` `@rustbot` modify labels: rollup
|
Best guess for #146223 (comment) @bors r- |
bors
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Sep 5, 2025
Update cc-rs to 1.2.33, and switch rustc_codegen_ssa to use find-msvc-tools try-job: dist-aarch64-linux
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 216bbad failed: CI. Failed jobs:
|
|
Yeah, seems likely, something about
|
|
Any way to get the I'd be happy to run some experiments if someone could delegate try permissions to me. |
|
@bors delegate=try |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Sorry, wrong bors |
|
✌️ @dpaoliello, you can now perform try builds on this pull request! You can now post |
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors2 try jobs=dist-aarch64-linux |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Sep 5, 2025
Update cc-rs to 1.2.33, and switch rustc_codegen_ssa to use find-msvc-tools try-job: dist-aarch64-linux
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test for 501f1bd failed: CI. Failed jobs:
|
|
There we go: Now, what to do about it? I'm not a Linux dev, so I have no idea what's gone wrong... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For my purposes, contains fixes when compiling the Rust compiler for Arm64EC.
Checked the commits since 1.2.16, and I don't see anything else that may affect Rust?
find-msvc-toolswas also factored out fromccto allow updating the use inrustc_codegen_ssa(finding the linker when running the Rust compiler) to be separate from the use inrustc_llvm(building LLVM as part of the Rust compiler).