Misc LTO cleanups #146209
Open
Misc LTO cleanups #146209
+62
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is only used within cg_llvm.
It is always false nowadays. ThinLTO summary writing is instead done by llvm_optimize.
The allocator shim no longer participates in LTO.
|
rustbot has assigned @workingjubilee. Use |
rustbot
added
A-LLVM
|
Some changes occurred in compiler/rustc_codegen_ssa Some changes occurred in compiler/rustc_codegen_gcc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #145955.
prepare_thin.Since The embedded bitcode should always be prepared for LTO/ThinLTO #133250 ThinLTO summary writing is instead done by
llvm_optimize.I noticed that I forgot to remove this in Rework how the codegen coordinator code handles the allocator shim #145955 while it was already being tested.