Skip to content

Rollup of 2 pull requests #146258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 6, 2025
Merged

Rollup of 2 pull requests #146258

merged 9 commits into from
Sep 6, 2025
+149 −31

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Sep 6, 2025 •
edited by rustbot
Loading

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Kobzol and others added 9 commits September 4, 2025 14:19
@Kobzol
Document Cargo with in-tree rustdoc
b5f2a71
@Kobzol
Allow specialization feature when documenting Cargo
9f9473f
@Kobzol
Respect top stage when documenting Cargo
a6aa509
@Kobzol
Add snapshot test for disting compiler docs
4375e9d
@Kobzol
Add a comment about the "specialization" feature required because of …
8c93cdc 
…`im-rc`
@Kobzol
Fix condition
b5c139b
@alexcrichton
std: Update wasi crate dependency
874dbd5 
The recent work on the WASIp2 target being integrated into the standard
library ended up causing a bug in nightly on the target. This has now
been fixed in the `wasi` crate so this commit pulls in the updated
version to ensure bindings work correctly.
@tgross35
Rollup merge of rust-lang#146199 - Kobzol:bootstrap-cargo-doc, r=jiey…
14415c7 
…ouxu

Document Cargo with in-tree rustdoc

Fixes https://rust-lang.zulipchat.com/#narrow/channel/266220-t-rustdoc/topic/nightly.20rust.20doc.20seem.20corrupted.

r? `@jieyouxu`

try-job: dist-x86_64-linux-alt
@tgross35
Rollup merge of rust-lang#146257 - alexcrichton:update-wasi-crate, r=…
e2698f8 
…tgross35

std: Update `wasi` crate dependency

The recent work on the WASIp2 target being integrated into the standard library (rust-lang#146207, rust-lang#145944) ended up causing a bug in nightly on the target. This [has now been fixed](bytecodealliance/wasi-rs#115) in the `wasi` crate so this commit pulls in the updated version to ensure bindings work correctly.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 6, 2025
@tgross35
Copy link
Contributor Author

tgross35 commented Sep 6, 2025

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Sep 6, 2025

📌 Commit e2698f8 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2025
@bors
Copy link
Collaborator

bors commented Sep 6, 2025

⌛ Testing commit e2698f8 with merge 545819d...

@bors
Copy link
Collaborator

bors commented Sep 6, 2025

☀️ Test successful - checks-actions
Approved by: tgross35
Pushing 545819d to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 6, 2025
@bors bors merged commit 545819d into rust-lang:master Sep 6, 2025
11 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 6, 2025
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#146199 Document Cargo with in-tree rustdoc 6ed7e3ae1c16fc3e3bf2addc2bf2ee30fe7a62ab (link)
#146257 std: Update wasi crate dependency 999803d6969b3acae64346f27310d3d163d9c95c (link)

previous master: 6c699a3723

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 6c699a3 (parent) -> 545819d (this PR)

Test differences

Show 7 test diffs

Stage 0

  • core::builder::tests::snapshot::dist_compiler_docs: [missing] -> pass (J0)
  • core::builder::tests::snapshot::doc_cargo_stage_1: [missing] -> pass (J0)
  • core::builder::tests::snapshot::doc_cargo_stage_2: [missing] -> pass (J0)

Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 545819dbd20aedb23979b58489956f0c532328a0 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-apple-various: 3413.4s -> 4026.8s (18.0%)
  2. dist-aarch64-apple: 6059.5s -> 7127.9s (17.6%)
  3. dist-armhf-linux: 5529.0s -> 4786.6s (-13.4%)
  4. pr-check-1: 1531.5s -> 1372.9s (-10.4%)
  5. x86_64-gnu-llvm-20-2: 6101.0s -> 5538.2s (-9.2%)
  6. x86_64-gnu-llvm-19-1: 3595.2s -> 3305.8s (-8.0%)
  7. dist-ohos-x86_64: 4490.6s -> 4137.2s (-7.9%)
  8. aarch64-apple: 5864.6s -> 5430.0s (-7.4%)
  9. tidy: 197.5s -> 183.3s (-7.2%)
  10. dist-aarch64-windows-gnullvm: 4925.2s -> 4583.0s (-6.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (545819d): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.8%, secondary 3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 3.2% [2.0%, 4.3%] 2
Improvements ✅
(primary)		 -2.8% [-2.8%, -2.8%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -2.8% [-2.8%, -2.8%] 1

Cycles

Results (secondary -0.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.2% [1.2%, 1.2%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.9% [-2.9%, -2.9%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 467.925s -> 468.318s (0.08%)
Artifact size: 390.56 MiB -> 390.56 MiB (-0.00%)

@bors bors mentioned this pull request Sep 6, 2025
Open
@tgross35 tgross35 deleted the rollup-4hqggwa branch September 6, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.
6 participants
@tgross35 @bors @rust-timer @rustbot @Kobzol @alexcrichton