Skip to content

Conversation

Qelxiros
Copy link
Contributor

@Qelxiros Qelxiros commented Sep 6, 2025

Tracking issue: #146179

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 6, 2025
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Qelxiros Qelxiros force-pushed the 146179-sliceindex-wrappers branch 3 times, most recently from 17736fe to dda0188 Compare September 10, 2025 18:52
@rust-log-analyzer

This comment has been minimized.

@Qelxiros Qelxiros force-pushed the 146179-sliceindex-wrappers branch from dda0188 to f847205 Compare September 10, 2025 19:41
@Qelxiros Qelxiros marked this pull request as ready for review September 10, 2025 21:35
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 10, 2025
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 10, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 10, 2025

r? @jhpratt

rustbot has assigned @jhpratt.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jhpratt
Copy link
Member

jhpratt commented Sep 13, 2025

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 13, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@Qelxiros Qelxiros force-pushed the 146179-sliceindex-wrappers branch from f847205 to 42bf2f8 Compare September 14, 2025 16:50
@Qelxiros
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 14, 2025
Copy link
Member

@jhpratt jhpratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! Would you mind adding a couple tests (beyond the doctests) that ensure the behavior works as expected? It should afaict, but tests are always nice :)

View changes since this review

#[unstable(feature = "sliceindex_wrappers", issue = "146179")]
impl Sealed for crate::index::Last {}
#[unstable(feature = "sliceindex_wrappers", issue = "146179")]
impl<T> Sealed for crate::index::Clamp<T> {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
impl<T> Sealed for crate::index::Clamp<T> {}
impl<T> Sealed for crate::index::Clamp<T> where T: Sealed {}

to avoid potentially leaking an implementation detail down the road

@Qelxiros Qelxiros force-pushed the 146179-sliceindex-wrappers branch 3 times, most recently from 5127f26 to 5381f1e Compare September 15, 2025 18:47
@rust-log-analyzer

This comment has been minimized.

@Qelxiros
Copy link
Contributor Author

looks like https://auth.docker.io/token is 500ing, causing the CI to fail

@Qelxiros Qelxiros force-pushed the 146179-sliceindex-wrappers branch from 5381f1e to 214e7b0 Compare September 15, 2025 19:10
@rustbot
Copy link
Collaborator

rustbot commented Sep 15, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer

This comment has been minimized.

@Qelxiros Qelxiros force-pushed the 146179-sliceindex-wrappers branch from 214e7b0 to 78d8ce7 Compare September 15, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants