Skip to content

Revert "Add LSX accelerated implementation for source file analysis" #146290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2025
Merged

Revert "Add LSX accelerated implementation for source file analysis" #146290

merged 1 commit into from
Sep 7, 2025
+3 −107

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Sep 7, 2025

This reverts commit 5b43244 to fix native build failures on LoongArch.

Link: #145963 (comment)
Link: #145963 (comment)

@heiher
Revert "Add LSX accelerated implementation for source file analysis"
58e2cd4 
This reverts commit 5b43244 to fix
native build failures on LoongArch.
@rustbot
Copy link
Collaborator

rustbot commented Sep 7, 2025

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 7, 2025
@lqd
Copy link
Member

lqd commented Sep 7, 2025

Weird that this wasn’t caught by CI.

r? lqd @bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 7, 2025

📌 Commit 58e2cd4 has been approved by lqd

It is now in the queue for this repository.

@rustbot rustbot assigned lqd and unassigned BoxyUwU Sep 7, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 7, 2025
Merged
bors added a commit that referenced this pull request Sep 7, 2025
@bors
Auto merge of #146292 - matthiaskrgr:rollup-bkjs887, r=matthiaskrgr
fbd8f95 
Rollup of 2 pull requests

Successful merges:

 - #146254 (Use `Itertools::all_equal_value()` where applicable)
 - #146290 (Revert "Add LSX accelerated implementation for source file analysis")

r? `@ghost`
`@rustbot` modify labels: rollup
@heiher
Copy link
Contributor Author

heiher commented Sep 7, 2025 •
edited
Loading

Weird that this wasn’t caught by CI.

Thanks for your review and sorry for the noise. I think the issue comes from cross-compilation: the host (x86_64) is built with stage0 compiler, while the target (loongarch64) is built with the host compiler. Since the host compiler differs from stage0, this mismatch didn't show up. It would be good if our CI could cover this case.

@bors bors merged commit 1b492b0 into rust-lang:master Sep 7, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Sep 7, 2025
@rust-timer
Unrolled build for #146290
12cced7 
Rollup merge of #146290 - heiher:r-src-analysis-lsx, r=lqd

Revert "Add LSX accelerated implementation for source file analysis"

This reverts commit 5b43244 to fix native build failures on LoongArch.

Link: #145963 (comment)
Link: #145963 (comment)
@rustbot rustbot added this to the 1.91.0 milestone Sep 7, 2025
@heiher heiher deleted the r-src-analysis-lsx branch September 7, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lqd lqd

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.91.0
Development

Successfully merging this pull request may close these issues.
5 participants
@heiher @rustbot @lqd @bors @BoxyUwU