-
Notifications
You must be signed in to change notification settings - Fork 13.7k
Use address reserved for docs in comment #146294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Addresses starting with "192.0.2.", "198.51.100.", or "203.0.113." are reserved for use in documentation and sample configurations. The original was some random french IP
https://doc.rust-lang.org/nightly/std/net/struct.Ipv4Addr.html#method.is_global documents such addresses as not being global, so I expect the doc test to fail. |
The job Click to see the possible cause of the failure (guessed by this bot)
|
According to https://www.iana.org/assignments/iana-ipv4-special-registry/iana-ipv4-special-registry.xhtml, these special addresses are global:
|
seems like this is an awkward method to write good docs for in that case... |
IPs have a one-hot classification, being a documentation IP means it isn't global https://play.rust-lang.org/?version=nightly&mode=debug&edition=2024&gist=4d02d0c8fe5827b36b87a3b9dbbc0605. Based on the comment from @hkBst this also seems like a correct classification for the two IPs in question here.
What makes the docs incorrect or bad? @rustbot author |
Reminder, once the PR becomes ready for a review, use |
Addresses starting with "192.0.2.", "198.51.100.", or "203.0.113." are reserved for use in documentation and sample configurations. The original was some random french IP, just changed it to an address reserved for documentation by the Internet Assigned Numbers Authority