Skip to content

Conversation

nnethercote
Copy link
Contributor

Minor improvements I found while looking through this code.

r? @BoxyUwU

Exhaustive match isn't necessary for these trivial cases, and some
similar nearby methods are non-exhaustive.
Because `rust_infer` is the only crate that uses it.
…::query`.

That way it doesn't need to be exported.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 7, 2025

changes to the core type system

cc @compiler-errors, @lcnr

@lcnr
Copy link
Contributor

lcnr commented Sep 8, 2025

r? lcnr

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 8, 2025

📌 Commit a171ec3 has been approved by lcnr

It is now in the queue for this repository.

@rustbot rustbot assigned lcnr and unassigned BoxyUwU Sep 8, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2025
bors added a commit that referenced this pull request Sep 8, 2025
Rollup of 7 pull requests

Successful merges:

 - #146111 (Migrate more things in the new solver to specific `DefId`s)
 - #146298 (GVN: Ensure indirect is first projection in try_as_place.)
 - #146299 (docs(std): add error docs for path canonicalize)
 - #146310 (Allow static regions in `type_name`.)
 - #146313 (Some `rustc_middle` cleanups)
 - #146319 (Fix typo in default.rs)
 - #146320 (rustc-dev-guide subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2eab500 into rust-lang:master Sep 8, 2025
10 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Sep 8, 2025
rust-timer added a commit that referenced this pull request Sep 8, 2025
Rollup merge of #146313 - nnethercote:rustc_middle-ty-cleanups-2, r=lcnr

Some `rustc_middle` cleanups

Minor improvements I found while looking through this code.

r? `@BoxyUwU`
@nnethercote nnethercote deleted the rustc_middle-ty-cleanups-2 branch September 8, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants