Rollup of 11 pull requests #146429
Merged
Rollup of 11 pull requests #146429
+576
−534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That test causes a large amount of crashes. If a system has a /proc/sys/kernel/core_pattern that uploads core dumps enabled, it will take a long time to complete. Set dumpable to 0 to avoid that. Before: $ time ./panic-uninitialized-zeroed real 0m47.457s user 0m0.023s sys 0m0.021s After: $ ./panic-uninitialized-zeroed real 0m0.029s user 0m0.019s sys 0m0.010s
This patch defines minimum CPU feature requirements, updates toolchain baseline, and streamlines maintainer list: - Specify double-precision floating-point and LSX as mandatory CPU features - Raise the minimum required binutils version to 2.42+, due to relocations introduced by the default medium code model - Remove outdated maintainers to reduce irrelevant notifications
also add INFO.md file explaining the purpouse of the ptr/docs dir.
Co-authored-by: Jubilee <workingjubilee@gmail.com>
Using the MCVE reported in RUST-145770.
…, r=petrochenkov" This reverts commit 1eeb8e8, reversing changes made to 324bf2b. Unfortunately the assert desugaring change is not backwards compatible, see RUST-145770. Code such as ```rust #[derive(Debug)] struct F { data: bool } impl std::ops::Not for F { type Output = bool; fn not(self) -> Self::Output { !self.data } } fn main() { let f = F { data: true }; assert!(f); } ``` would be broken by the assert desugaring change. We may need to land the change over an edition boundary, or limit the editions that the desugaring change impacts.
…39190-pt3, r=workingjubilee core::ptr: deduplicate docs for as_ref, addr, and as_uninit_ref also add INFO.md file explaining the purpose of the ptr/docs dir, and give some pointers (heh) to future maintainers. follow up to rust-lang#142101 part of rust-lang#139190 r? `@workingjubilee`
disable core dumps for panic-uninitialized-zeroed That test causes a large amount of crashes. If a system has a /proc/sys/kernel/core_pattern that uploads core dumps enabled, it will take a long time to complete. Set dumpable to 0 to avoid that. Before: ``` $ time ./panic-uninitialized-zeroed real 0m47.457s user 0m0.023s sys 0m0.021s ``` After: ``` $ ./panic-uninitialized-zeroed real 0m0.029s user 0m0.019s sys 0m0.010s ```
… r=fee1-dead report duplicate symbols added by the driver The panic message did not mention what symbols were duplicates, which made the panic hard to debug. This came up in [#t-compiler/help > Easiest way to find offending duplicate symbols](https://rust-lang.zulipchat.com/#narrow/channel/182449-t-compiler.2Fhelp/topic/Easiest.20way.20to.20find.20offending.20duplicate.20symbols/with/538295740). This behavior was introduced in rust-lang#138682. r? ```@fee1-dead```
…jieyouxu Update the LoongArch target documentation This patch defines minimum CPU feature requirements, updates toolchain baseline, and streamlines maintainer list: - Specify double-precision floating-point and LSX as mandatory CPU features - Raise the minimum required binutils version to 2.42+, due to relocations introduced by the default medium code model - Remove outdated maintainers to reduce irrelevant notifications r? `@jieyouxu`
… r=tgross35 Fix `compare_against_sw_vers` test The `saturating_sub` doesn't actually perform its intended since the version numbers are signed integers (which I changed in a later revision of rust-lang#138944). Fixes the issue described in rust-lang#138944 (comment). r? tgross35
…float_tests, r=tgross35 Unify and deduplicate bits conv float tests cc rust-lang#141726 This is a proposal to unify and deduplicate the bits conv tests for f16, f32, f64 and f128
…gjubilee s390x: mark soft-float target feature as incompatible This provides a more informative warning when someone manually sets `+soft-float` on s390x.
…nds, r=estebank Less greedily parse `[const]` bounds > [!IMPORTANT] > If you're coming here from any beta backport nomination thread on Zulip, only the last commit is truly relevant (the first commit doesn't need to be backported, it only contains test modifications)! Don't consider `[` to start a bound, only consider `[const]` in its entirety to do so. This drastically reduces (but doesn't eliminate!) the chance of *real* breakages. Like `const`, `~const` and `async` before, `[const]` unavoidably brings along theoretical breakages, see preexisting tests: `macro-const-trait-bound-theoretical-regression.rs` and `macro-async-trait-bound-theoretical-regression.rs`. Side note: It's unfortunate that we have to do this but apart from the known fact that MBE hurts forward compatibility, the `[const]` syntax is simply a bit scuffed (also CC'ing rust-lang#146122, section (3)). Fixes [after beta backport] rust-lang#146417. * 1st commit: Restore the original test intentions of several preexisting related tests that were unfortunately lost over time * I've added a bunch of SCREAMING comments to make it less likely to be lost again * CC PR rust-lang#119099 which added most of these tests * CC [rust-lang#144409 (comment)](rust-lang#144409 (comment)) for further context (NB: It's not the only PR that negatively affected the test intention) * 2nd commit: Actually address the regression r? `@oli-obk` or anyone
…ge, r=workingjubilee Improve `core::ops` coverage This PR improves the `core::ops` coverage by adding new tests to `coretests`
…rage, r=workingjubilee Improve `core::array` coverage This PR improves the `core::array` coverage by adding new tests to `coretests`
… r=estebank,jackh726 Revert `assert!` desugaring changes (rust-lang#122661) Reverts rust-lang#122661 to prevent rust-lang#145770 slipping into beta. cc `@estebank` (FYI) ### Review remarks - Commit 1 is the MCVE reported in rust-lang#145770 added as a regression test `tests/ui/macros/assert-desugaring-145770.rs`. Against `master`, this test fails. - Commit 2 reverts rust-lang#122661 (with a merge conflict fixed). `tests/ui/macros/assert-desugaring-145770.rs` now passes.
rustbot
added
O-apple
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 11, 2025
Rollup of 11 pull requests Successful merges: - #142315 (core::ptr: deduplicate docs for as_ref, addr, and as_uninit_ref) - #146335 (disable core dumps for panic-uninitialized-zeroed) - #146347 (report duplicate symbols added by the driver) - #146370 (Update the LoongArch target documentation) - #146379 (Fix `compare_against_sw_vers` test) - #146380 (Unify and deduplicate bits conv float tests) - #146415 (s390x: mark soft-float target feature as incompatible) - #146422 (Less greedily parse `[const]` bounds) - #146424 (Improve `core::ops` coverage) - #146425 (Improve `core::array` coverage) - #146428 (Revert `assert!` desugaring changes (#122661)) r? `@ghost` `@rustbot` modify labels: rollup
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry (runner flaked out) |
bors
added
S-waiting-on-bors
|
@bors try jobs=test-various,dist-various,x86_64-gnu-llvm-19-3 |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Sep 11, 2025
Rollup of 11 pull requests try-job: test-various try-job: dist-various try-job: x86_64-gnu-llvm-19-3
|
💔 Test for fa4163d failed: CI. Failed job:
|
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
|
Whoops, messed up one of the job names. At this point there's little benefit in running advance try jobs; might as well just wait for the real thing. |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 5e33838 (parent) -> 76c5ed2 (this PR) Test differencesShow 261 test diffsStage 1
Stage 2
Additionally, 214 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 76c5ed2847cdb26ef2822a3a165d710f6b772217 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
📌 Perf builds for each rolled up PR:
previous master: 5e33838cca In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
|
Finished benchmarking commit (76c5ed2): comparison URL. Overall result: ❌✅ regressions and improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -0.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 0.8%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.0%, secondary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 468.387s -> 466.951s (-0.31%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
compare_against_sw_verstest #146379 (Fixcompare_against_sw_verstest)[const]bounds #146422 (Less greedily parse[const]bounds)core::opscoverage #146424 (Improvecore::opscoverage)core::arraycoverage #146425 (Improvecore::arraycoverage)assert!desugaring changes (#122661) #146428 (Revertassert!desugaring changes (Change the desugaring ofassert!for better error output #122661))r? @ghost
@rustbot modify labels: rollup
Create a similar rollup