Skip to content

Conversation

DimitriiTrater
Copy link

@DimitriiTrater DimitriiTrater commented Sep 11, 2025

Fixes #136275

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 11, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 11, 2025

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Copy link
Contributor

@GrigorenkoPV GrigorenkoPV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it would make more sense to rephrase the existing part in terms of >= +0.0 and <= -0.0 instead of adding a new section?

View changes since this review

@DimitriiTrater
Copy link
Author

If you take into account the signs of zeros in the function definition, then it will not make mathematical sense.
Signs of zeros in this context make sense only if we are talking about IEEE-754.
If you do it the way you say, then I need to remove the mathematical definition of the function from arctan and leave only the areas of incoming and outgoing values.

@DimitriiTrater
Copy link
Author

DimitriiTrater commented Sep 12, 2025

I can suggest this:
x >= +0, y >= +0: [0, π/2]
x <= -0, y >= +0: [π/2, π]
x >= +0, y <= -0: [-π/2, 0]
x <= -0, y <= -0: [-π, -π/2]

@GrigorenkoPV what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

f64::atan2 documentation error
4 participants