c-variadic: unseal core::ffi::VaArgSafe
#146454
Open
+2
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And update the safety documentation
rustbot
added
S-waiting-on-review
|
|
folkertdev
commented
Sep 11, 2025
Comment on lines
-209
to
+192
| /// This trait must only be implemented for types that C passes as varargs without implicit promotion. | ||
| /// Implementing this trait asserts that the type can be soundly passed via varargs. |
There was a problem hiding this comment.
Suggestions are welcome. VaList::arg is still also unsafe, so really what this trait does is disallow a couple of cases that will clearly not work, and make users explicitly opt-in to anything more exotic than fundamental types that have direct equivalents in (older) C.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracking issue: #44930
We concluded that this trait should be implementable by end users. Many ABIs do support passing additional types (128-bit integers, SIMD vectors, composite types).
r? @workingjubilee