-
Notifications
You must be signed in to change notification settings - Fork 13.7k
std: simplify host lookup #146541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joboet
wants to merge
1
commit into
rust-lang:master
Choose a base branch
from
joboet:simplify-lookup-host
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
std: simplify host lookup #146541
+50
−193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
hkBst
approved these changes
Sep 14, 2025
cd0ffd9
to
3f42540
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for splitting up a string into a hostname and port is currently duplicated across (nearly) all of the networking implementations in
sys
. Since it does not actually rely on any system internals, this PR moves it to theToSocketAddr
implementation for&str
, making it easier to discover and maintain.On the other hand, the
ToSocketAddr
implementation (or rather theresolve_socket_addr
function) contained logic to overwrite the port on the socket addresses returned byLookupHost
, even thoughLookupHost
is already aware of the port and sets the port already on Xous. This PR thus removes this logic by moving the responsibility of setting the port to the system-specificLookupHost
implementation.As a consequence of these changes, there remains only one way of creating
LookupHost
, hence I've removed theTryFrom
implementations in favour of alookup_host
function, mirroring other, public iterator-based features.And finally, I've simplified the parsing logic responsible for recognising IP addresses passed to
<(&str, u16)>::to_socket_addrs()
by using theFromStr
impl ofIpAddr
rather than duplicating the parsing for both IP versions.