add trait impls to proc_macro::Ident #146553

Qelxiros · 2025-09-14T19:41:43Z

rustbot · 2025-09-14T19:41:48Z

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rust-log-analyzer · 2025-09-14T22:08:03Z

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

tests/ui/size_of_in_element_count/functions.rs ... ok
tests/ui/crashes/third-party/conf_allowlisted.rs ... ok

FAILED TEST: tests/ui/allow_attributes_without_reason.rs
command: CLIPPY_CONF_DIR="tests" RUSTC_ICE="0" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/clippy-driver" "--error-format=json" "--emit=metadata" "-Aunused" "-Ainternal_features" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Dwarnings" "-Ldependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "--sysroot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--crate-type=proc-macro" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/tests/ui/auxiliary" "tests/ui/auxiliary/proc_macros.rs" "--extern" "futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libfutures-d09847362e37b509.rlib" "--extern" "futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libfutures-d09847362e37b509.rmeta" "--extern" "itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libitertools-c2422b3a3e40490d.rlib" "--extern" "itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libitertools-c2422b3a3e40490d.rmeta" "--extern" "libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/liblibc-aa5f6084485e7ae6.rlib" "--extern" "libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/liblibc-aa5f6084485e7ae6.rmeta" "--extern" "parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libparking_lot-0bf1a04a55d93396.rlib" "--extern" "parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libparking_lot-0bf1a04a55d93396.rmeta" "--extern" "quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libquote-cb32a199a663244b.rlib" "--extern" "quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libquote-cb32a199a663244b.rmeta" "--extern" "regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libregex-233f3bdf9b3b6d0e.rlib" "--extern" "regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libregex-233f3bdf9b3b6d0e.rmeta" "--extern" "serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libserde-5ec1d26ba0d2ceb6.rlib" "--extern" "serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libserde-5ec1d26ba0d2ceb6.rmeta" "--extern" "syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libsyn-db9be95975733746.rlib" "--extern" "syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libsyn-db9be95975733746.rmeta" "--extern" "tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libtokio-fedb71cb00cbbffd.rlib" "--extern" "tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libtokio-fedb71cb00cbbffd.rmeta" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/debug/deps" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps" "--edition" "2024" "--emit=link"

error: aux build failed
##[error] --> tests/ui/allow_attributes_without_reason.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/allow_attributes_without_reason.rs
  |
error: compilation of aux build failed failed with exit status: 1


full stderr:
error: this creates an owned instance just for comparison
##[error]  --> tests/ui/auxiliary/proc_macros.rs:468:20
   |
LL |                 && name.to_string() == "inline"
   |                    ^^^^^^^^^^^^^^^^ help: try: `*name`
   |
   = note: `-D clippy::cmp-owned` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::cmp_owned)]`

error: aborting due to 1 previous error
---

error: aux build failed
##[error] --> tests/ui/allow_attributes.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/allow_attributes.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/almost_complete_range.rs:2:14
  |
2 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/almost_complete_range.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/arc_with_non_send_sync.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/arc_with_non_send_sync.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/as_conversions.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/as_conversions.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/borrow_as_ptr.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/borrow_as_ptr.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/borrow_deref_ref.rs:1:15
  |
1 | //@aux-build: proc_macros.rs
  |               ^^^^^^^^^^^^^^ tests/ui/borrow_deref_ref.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/default_numeric_fallback_f64.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/default_numeric_fallback_f64.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/default_numeric_fallback_i32.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/default_numeric_fallback_i32.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/default_trait_access.rs:1:15
  |
1 | //@aux-build: proc_macros.rs
  |               ^^^^^^^^^^^^^^ tests/ui/default_trait_access.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/deref_addrof_macro.rs:2:14
  |
2 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/deref_addrof_macro.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/disallowed_names.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/disallowed_names.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/doc_unsafe.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/doc_unsafe.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/empty_loop.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/empty_loop.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/equatable_if_let.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/equatable_if_let.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/extra_unused_type_parameters.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/extra_unused_type_parameters.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/field_reassign_with_default.rs:2:14
  |
2 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/field_reassign_with_default.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/filter_map_bool_then.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/filter_map_bool_then.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/four_forward_slashes.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/four_forward_slashes.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/implicit_hasher.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/implicit_hasher.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/implicit_return.rs:1:15
  |
1 | //@aux-build: proc_macros.rs
  |               ^^^^^^^^^^^^^^ tests/ui/implicit_return.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/inconsistent_struct_constructor.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/inconsistent_struct_constructor.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/indexing_slicing_index.rs:2:15
  |
2 | //@aux-build: proc_macros.rs
  |               ^^^^^^^^^^^^^^ tests/ui/indexing_slicing_index.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/indexing_slicing_slice.rs:1:15
  |
1 | //@aux-build: proc_macros.rs
  |               ^^^^^^^^^^^^^^ tests/ui/indexing_slicing_slice.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/infinite_loops.rs:2:14
  |
2 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/infinite_loops.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/into_iter_without_iter.rs:2:14
  |
2 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/into_iter_without_iter.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/iter_over_hash_type.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/iter_over_hash_type.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/iter_skip_zero.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/iter_skip_zero.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/iter_without_into_iter.rs:2:14
  |
2 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/iter_without_into_iter.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/large_enum_variant.rs:2:14
  |
2 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/large_enum_variant.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/large_stack_arrays.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/large_stack_arrays.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/legacy_numeric_constants.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/legacy_numeric_constants.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/legacy_numeric_constants_unfixable.rs:3:14
  |
3 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/legacy_numeric_constants_unfixable.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/let_underscore_untyped.rs:1:15
  |
1 | //@aux-build: proc_macros.rs
  |               ^^^^^^^^^^^^^^ tests/ui/let_underscore_untyped.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/let_with_type_underscore.rs:1:15
  |
1 | //@aux-build: proc_macros.rs
  |               ^^^^^^^^^^^^^^ tests/ui/let_with_type_underscore.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/manual_float_methods.rs:2:14
  |
2 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/manual_float_methods.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/manual_is_multiple_of.rs:1:15
  |
1 | //@aux-build: proc_macros.rs
  |               ^^^^^^^^^^^^^^ tests/ui/manual_is_multiple_of.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/manual_rem_euclid.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/manual_rem_euclid.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/manual_slice_size_calculation.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/manual_slice_size_calculation.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/manual_try_fold.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/manual_try_fold.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/mem_replace_macro.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/mem_replace_macro.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/min_ident_chars.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/min_ident_chars.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/missing_doc.rs:2:15
  |
2 | //@aux-build: proc_macros.rs
  |               ^^^^^^^^^^^^^^ tests/ui/missing_doc.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/missing_doc_impl.rs:1:15
  |
1 | //@aux-build: proc_macros.rs
  |               ^^^^^^^^^^^^^^ tests/ui/missing_doc_impl.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/mistyped_literal_suffix.rs:1:15
  |
1 | //@aux-build: proc_macros.rs
  |               ^^^^^^^^^^^^^^ tests/ui/mistyped_literal_suffix.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/multiple_unsafe_ops_per_block.rs:2:14
  |
2 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/multiple_unsafe_ops_per_block.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/must_use_unit.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/must_use_unit.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/mut_mut.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/mut_mut.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/needless_if.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/needless_if.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/needless_late_init.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/needless_late_init.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/needless_lifetimes.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/needless_lifetimes.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/needless_maybe_sized.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/needless_maybe_sized.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/needless_pub_self.rs:2:14
  |
2 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/needless_pub_self.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/needless_return.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/needless_return.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/needless_return_with_question_mark.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/needless_return_with_question_mark.rs
  |

full stderr:
previous build failed
full stdout:



FAILED TEST: tests/ui/non_canonical_clone_impl.rs
command: CLIPPY_CONF_DIR="tests" RUSTC_ICE="0" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/clippy-driver" "--error-format=json" "--emit=metadata" "-Aunused" "-Ainternal_features" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Dwarnings" "-Ldependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/release/deps" "--sysroot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--crate-type=lib" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/tests/ui" "tests/ui/non_canonical_clone_impl.rs" "--extern" "proc_macro_derive=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/tests/ui/auxiliary/libproc_macro_derive.so" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/tests/ui/auxiliary" "--extern" "futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libfutures-d09847362e37b509.rlib" "--extern" "futures=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libfutures-d09847362e37b509.rmeta" "--extern" "itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libitertools-c2422b3a3e40490d.rlib" "--extern" "itertools=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libitertools-c2422b3a3e40490d.rmeta" "--extern" "libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/liblibc-aa5f6084485e7ae6.rlib" "--extern" "libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/liblibc-aa5f6084485e7ae6.rmeta" "--extern" "parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libparking_lot-0bf1a04a55d93396.rlib" "--extern" "parking_lot=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libparking_lot-0bf1a04a55d93396.rmeta" "--extern" "quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libquote-cb32a199a663244b.rlib" "--extern" "quote=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libquote-cb32a199a663244b.rmeta" "--extern" "regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libregex-233f3bdf9b3b6d0e.rlib" "--extern" "regex=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libregex-233f3bdf9b3b6d0e.rmeta" "--extern" "serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libserde-5ec1d26ba0d2ceb6.rlib" "--extern" "serde=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libserde-5ec1d26ba0d2ceb6.rmeta" "--extern" "syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libsyn-db9be95975733746.rlib" "--extern" "syn=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libsyn-db9be95975733746.rmeta" "--extern" "tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libtokio-fedb71cb00cbbffd.rlib" "--extern" "tokio=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps/libtokio-fedb71cb00cbbffd.rmeta" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/debug/deps" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/ui_test/0/x86_64-unknown-linux-gnu/debug/deps" "--edition" "2024"

error: actual output differed from expected
Execute `./x test src/tools/clippy --bless` to update `tests/ui/non_canonical_clone_impl.stderr` to the actual output
--- tests/ui/non_canonical_clone_impl.stderr
+++ <stderr output>
---
-   |  _____________________________^
-LL | |
-LL | |         Self(self.0)
-LL | |     }
-   | |_____^ help: change this to: `{ *self }`
-   |
-   = note: `-D clippy::non-canonical-clone-impl` implied by `-D warnings`
-   = help: to override `-D warnings` add `#[allow(clippy::non_canonical_clone_impl)]`
+LL | extern crate proc_macros;
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^ can't find crate
---
-   |  _____________________________^
-LL | |
-LL | |         Self(self.0)
-LL | |     }
-   | |_____^ help: change this to: `{ *self }`
-
-error: unnecessary implementation of `clone_from` on a `Copy` type
-  --> tests/ui/non_canonical_clone_impl.rs:92:5
-   |
-LL | /     fn clone_from(&mut self, source: &Self) {
---

error: aux build failed
##[error] --> tests/ui/option_env_unwrap.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/option_env_unwrap.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/patterns.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/patterns.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/ptr_as_ptr.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/ptr_as_ptr.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/ptr_cast_constness.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/ptr_cast_constness.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/pub_with_shorthand.rs:2:14
  |
2 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/pub_with_shorthand.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/pub_without_shorthand.rs:2:14
  |
2 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/pub_without_shorthand.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/redundant_at_rest_pattern.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/redundant_at_rest_pattern.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/redundant_field_names.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/redundant_field_names.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/redundant_guards.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/redundant_guards.rs
  |

full stderr:
previous build failed
full stdout:
---
stack backtrace:
error: aux build failed
##[error] --> tests/ui/redundant_locals.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/redundant_locals.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/redundant_pub_crate.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/redundant_pub_crate.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/reserve_after_initialization.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/reserve_after_initialization.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/single_call_fn.rs:2:14
  |
2 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/single_call_fn.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/single_match_else.rs:1:15
  |
1 | //@aux-build: proc_macros.rs
  |               ^^^^^^^^^^^^^^ tests/ui/single_match_else.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/single_range_in_vec_init.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/single_range_in_vec_init.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/string_add.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/string_add.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/string_lit_chars_any.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/string_lit_chars_any.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/struct_fields.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/struct_fields.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/toplevel_ref_arg.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/toplevel_ref_arg.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/toplevel_ref_arg_non_rustfix.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/toplevel_ref_arg_non_rustfix.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/try_err.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/try_err.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/tuple_array_conversions.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/tuple_array_conversions.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/uninlined_format_args.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/uninlined_format_args.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/unit_arg.rs:1:15
  |
1 | //@aux-build: proc_macros.rs
  |               ^^^^^^^^^^^^^^ tests/ui/unit_arg.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/unnecessary_fallible_conversions_unfixable.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/unnecessary_fallible_conversions_unfixable.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/unnecessary_lazy_eval.rs:1:15
  |
1 | //@aux-build: proc_macros.rs
  |               ^^^^^^^^^^^^^^ tests/ui/unnecessary_lazy_eval.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/unnecessary_map_or.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/unnecessary_map_or.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/unnecessary_unsafety_doc.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/unnecessary_unsafety_doc.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/unneeded_field_pattern.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/unneeded_field_pattern.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/unneeded_wildcard_pattern.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/unneeded_wildcard_pattern.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/unused_result_ok.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/unused_result_ok.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/unused_trait_names.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/unused_trait_names.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/useless_concat.rs:1:14
  |
1 | //@aux-build:proc_macros.rs
  |              ^^^^^^^^^^^^^^ tests/ui/useless_concat.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/crashes/ice-10148.rs:1:14
  |
1 | //@aux-build:../auxiliary/proc_macros.rs
  |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ tests/ui/crashes/ice-10148.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/items_after_test_module/after_proc_macros.rs:2:14
  |
2 | //@aux-build:../auxiliary/proc_macros.rs
  |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ tests/ui/items_after_test_module/after_proc_macros.rs
  |

full stderr:
previous build failed
full stdout:
---

error: aux build failed
##[error] --> tests/ui/missing_const_for_fn/cant_be_const.rs:7:14
  |
7 | //@aux-build:../auxiliary/proc_macros.rs
  |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^ tests/ui/missing_const_for_fn/cant_be_const.rs
  |

full stderr:
previous build failed
full stdout:

rustbot assigned petrochenkov Sep 14, 2025

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 14, 2025

Qelxiros force-pushed the ident_impls branch from 55be783 to fee6f71 Compare September 14, 2025 19:47

This comment has been minimized.

Sign in to view

Qelxiros force-pushed the ident_impls branch from fee6f71 to 624c863 Compare September 14, 2025 20:20

This comment has been minimized.

Sign in to view

add trait impls to proc_macro::Ident

509f080

Qelxiros force-pushed the ident_impls branch from 624c863 to 509f080 Compare September 14, 2025 21:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add trait impls to proc_macro::Ident #146553

add trait impls to proc_macro::Ident #146553

Qelxiros commented Sep 14, 2025

Uh oh!

rustbot commented Sep 14, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-log-analyzer commented Sep 14, 2025

Uh oh!

Uh oh!

add trait impls to proc_macro::Ident #146553

Are you sure you want to change the base?

add trait impls to proc_macro::Ident #146553

Conversation

Qelxiros commented Sep 14, 2025

Uh oh!

rustbot commented Sep 14, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-log-analyzer commented Sep 14, 2025

Uh oh!

Uh oh!