Fix uses of "adaptor" #146632
Open
Fix uses of "adaptor" #146632
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These docs are in en_US, so "adapter" is the correct spelling (and indeed used in the next line.)
rustbot
added
S-waiting-on-review
|
rustbot has assigned @petrochenkov. Use |
bjorn3
reviewed
Sep 16, 2025
| //@ check-pass | ||
|
|
||
| // Fixes a regression in icu_provider_adaptors where we weren't normalizing the | ||
| // Fixes a regression in icu_provider_adapters where we weren't normalizing the |
There was a problem hiding this comment.
This refers to a particular crate, so it shouldn't be changed for consistency with other uses of the word adapters. However it just so happens that the old version was a typo. The crate is called icu_provider_adapters, not icu_provider_adaptors
There was a problem hiding this comment.
Quite right! I checked the naming of the upstream crate when making this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These docs are in en_US, so "adapter" is the correct spelling (and indeed used in the next line.)
A second commit comes along for the ride to fix other instances in non-rustdoc comments.