Skip to content

Rollup of 15 pull requests #146665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 50 commits into from
Closed

Rollup of 15 pull requests #146665

wants to merge 50 commits into from

Conversation

Zalathar
Copy link
Contributor

@Zalathar Zalathar commented Sep 17, 2025 •
edited by rustbot
Loading

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

sourcefrog and others added 30 commits June 20, 2025 13:22
@sourcefrog
libtest: expose --fail-fast
4acf3ba
@sourcefrog
Make fail-fast unstable
547c729
@Kivooeo
remove gates
b5a4e5d
@dianne
add tests, some with incorrect lifetime extension behavior
9fd57df
@dianne
don't extend non-extended super let initializers' block tail temps
0976d6c
@dianne @traviscross
additional tests
d5b5a4a 
Co-authored-by: Travis Cross <tc@traviscross.com>
@jbatez
initial implementation of the darwin_objc unstable feature
1ebf69d
@cjgillot
Lint overlapping assignments in MIR.
acf0615
@estebank
Detect attempt to use var-args in closure
9405e76 
```
error: unexpected `...`
  --> $DIR/varargs-in-closure-isnt-supported.rs:5:20
   |
LL |     let mut lol = |...| ();
   |                    ^^^ not a valid pattern
   |
   = note: C-variadic type `...` is not allowed here
```
@estebank
Silence inference error on PatKind::Err
0e290e4
@estebank
Fix existing test
a84c8de
@Gelbpunkt
tests/run-make: Update list of statically linked musl targets
53b58b3 
All of the tier 3 targets in the list now link dynamically by default
(except mips64el-unknown-linux-muslabi64, I overlooked that one).

Adjust the list of targets expected to link statically accordingly.

Signed-off-by: Jens Reidel <adrian@travitia.xyz>
@tnuha
remove FIXME from has_significant_drop, replaced with checking non_…
fa7e474 
…region_infer
@camsteffen @jackh726
Suggest removing Box::new
d66fb49
@hkBst
Iterator repeat: no infinite loop for last and count
c89b6a9
@estebank
fmt
c916e88
@estebank
remove redundant test
ed85f98
@estebank
Reword note
8306a2f
@estebank
Detect top-level ... in argument type
e9270e3 
When writing something like the expression `|_: ...| {}`, we now detect the `...` during parsing explicitly instead of relying on the detection in `parse_ty_common` so that we don't talk about "nested `...` are not supported".

```
error: unexpected `...`
  --> $DIR/no-closure.rs:6:35
   |
LL | const F: extern "C" fn(...) = |_: ...| {};
   |                                   ^^^
   |
   = note: only `extern "C"` and `extern "C-unwind"` functions may have a C variable argument list
```
@cuviper
Update the minimum external LLVM to 20
580b489
@cuviper
Merge similar output checks in assembly-llvm/x86_64-cmp
e54602c
@cuviper
Update the FIXME comments in the generic three_way_compare
88bef49
@simp4t7
add Readme.md to tidy
d81872a 
update Readme

add info about githooks and bootstrap.toml

add info about config and remove linting specific files

add link to rustc-dev-guide
@cjgillot
Remove Rvalue::Len.
53b91ea
@cjgillot
Update docs.
f018b46
@cjgillot
Add test.
de73af9
@cjgillot
Add test.
40d879a
@cjgillot
Do not renumber resume local.
fe3a784
@cjgillot
Bless ui.
eddd755
@Zalathar
Use LLVMDIBuilderCreateSubroutineType
5419896
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Sep 17, 2025
@Zalathar
Copy link
Contributor Author

Making a new rollup of everything, because #146662 had a runner flake out, and there are a few rollup=never PRs to fall back to if this fails.

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented Sep 17, 2025

📌 Commit 51ac5cb has been approved by Zalathar

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2025
@Zalathar
Copy link
Contributor Author

Pre-trying a few jobs in parallel.

@bors try jobs=test-various,dist-various-1,aarch64-apple,i686-msvc-1,i686-msvc-2

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Sep 17, 2025
@rust-bors
Auto merge of #146665 - Zalathar:rollup-m0jawc2, r=<try>
5d12a45 
Rollup of 15 pull requests

try-job: test-various
try-job: dist-various-1
try-job: aarch64-apple
try-job: i686-msvc-1
try-job: i686-msvc-2
@rust-log-analyzer
Copy link
Collaborator

The job pr-check-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-apple failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@rust-bors
Copy link

rust-bors bot commented Sep 17, 2025

💔 Test for 5d12a45 failed: CI. Failed jobs:

@Zalathar
Copy link
Contributor Author

Looks like a soft conflict between #146564 and #146566.

@Zalathar
Copy link
Contributor Author

I'll re-rollup without the conflict.

@Zalathar Zalathar closed this Sep 17, 2025
@Zalathar Zalathar mentioned this pull request Sep 17, 2025
Merged
@Zalathar Zalathar deleted the rollup-m0jawc2 branch September 17, 2025 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc A-tidy Area: The tidy tool O-apple Operating system: Apple (macOS, iOS, tvOS, visionOS, watchOS) rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.