Skip to content

Remove ImplSubject #146694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove ImplSubject #146694

wants to merge 1 commit into from
+7 −61

Conversation

camsteffen
Copy link
Contributor

It only has one usage in rustdoc.

@rustbot
Copy link
Collaborator

rustbot commented Sep 17, 2025

changes to the core type system

cc @compiler-errors, @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 17, 2025
@rustbot rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Sep 17, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 17, 2025

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@compiler-errors
Copy link
Member

r=me when ci is green

r? compiler-errors

@rustbot rustbot assigned compiler-errors and unassigned jackh726 Sep 17, 2025
@fmease
Copy link
Member

fmease commented Sep 18, 2025

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Sep 18, 2025

📌 Commit 9ecca51 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Sep 18, 2025
@Zalathar
Rollup merge of rust-lang#146694 - camsteffen:impl-subject, r=compile…
06cbfd6 
…r-errors

Remove ImplSubject

It only has one usage in rustdoc.
@Zalathar Zalathar mentioned this pull request Sep 18, 2025
Open
bors added a commit that referenced this pull request Sep 18, 2025
@bors
Auto merge of #146698 - Zalathar:rollup-0oxl4gx, r=Zalathar
4793ef5 
Rollup of 5 pull requests

Successful merges:

 - #146566 (Lint more overlapping assignments in MIR.)
 - #146645 (Cleanup `FnDecl::inner_full_print`)
 - #146664 (Clean up `ty::Dynamic`)
 - #146673 (cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bindings (part 4))
 - #146694 (Remove ImplSubject)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@camsteffen @rustbot @compiler-errors @fmease @bors @jackh726