Clean up universe evaluation during type test evaluation #146717
Merged
+18
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
amandasystems
force-pushed
the
remove-placeholder-hack
branch
from
d2b9fd0 to
b76881b
Compare
The logic was, as the removed comments suggest, hackish and meant to implement previous logic that was factored out. The new logic does exactly what the comments say, and is much less surprising.
This comment has been minimized.
This comment has been minimized.
amandasystems
force-pushed
the
remove-placeholder-hack
branch
from
76d8493 to
2ed5373
Compare
Done! Managed to commit, squash and reformat from my phone. We’re living in the future! |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 18, 2025
Rollup of 6 pull requests Successful merges: - #146434 (c-variadic: allow c-variadic inherent and trait methods) - #146487 (Improve `core::num` coverage) - #146597 (Add span for struct tail recursion limit error) - #146622 (Add regression test for issue #91831) - #146717 (Clean up universe evaluation during type test evaluation) - #146723 (Include patch in release notes) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Sep 18, 2025
Rollup merge of #146717 - amandasystems:remove-placeholder-hack, r=lcnr Clean up universe evaluation during type test evaluation The logic was, as the removed comments suggest, hackish and meant to implement previous logic that was factored out. The new logic does exactly what the comments say, and is much less surprising. I'm afraid we may want r? `@lcnr` for this one too. I am sorry, but at least it should be easier to review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic was, as the removed comments suggest, hackish and meant to implement previous logic that was factored out. The new logic does exactly what the comments say, and is much less surprising.
I'm afraid we may want
r? @lcnr
for this one too.
I am sorry, but at least it should be easier to review.