Ignore tests in tests/ui/abi for the GCC backend
#146779
Open
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-compiletest
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
This comment has been minimized.
This comment has been minimized.
GuillaumeGomez
force-pushed
the
gcc-ignore-test_ui_abi
branch
from
ee9ff3c to
0471d9c
Compare
|
CI passed. :) |
|
Hmm, I'd maybe like it more if we just marked all those tests as being LLVM only (or maybe had some "default test directives" per directory?), and then perhaps have a tidy check that ensures that indeed all tests are marked as such, to make the fact that these tests are being skipped more explicit. That being said, we already have the opt-out for the assembly and codegen tests, so this doesn't seem terribly different from that. I'd like to hear @jieyouxu's opinion, but otherwise looks fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #146414.
Currently we ignore them in the GCC backend and until this situation changes, it'll block #146414.
r? @Kobzol