Skip to content

mbe: Simplifications and refactoring #146802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

mbe: Simplifications and refactoring #146802

wants to merge 3 commits into from
+39 −31

Conversation

joshtriplett
Copy link
Member

A few simplifications and refactors in advance of other work.

Macro metavariable expressions were using Ident::as_str and doing string
comparisons; I converted them to use symbols.

I factored out a function for transcribing a ParseNtResult, which will help
separate the evaluation and transcription of future macro metavariable
expressions.

@joshtriplett
mbe: Simplify match in transcribe_metavar
bb430f8 
Factor out the check for a variable that's still repeating.
@joshtriplett
mbe: Factor out a function to transcribe a ParseNtResult
fc41c38
@joshtriplett
mbe: metavar expressions: Use symbols rather than ident.as_str()
a54111a 
Identify metavariable functions by using named symbols rather than
string comparisons.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 20, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 20, 2025

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@joshtriplett
Copy link
Member Author

r? @petrochenkov

@rustbot rustbot assigned petrochenkov and unassigned jackh726 Sep 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshtriplett @rustbot @petrochenkov @jackh726