-
Notifications
You must be signed in to change notification settings - Fork 13.8k
fully deprecate the legacy integral modules #146882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
I'm still kind of meh on these deprecations personally, but we should probably finish what was started. With that said, I'm strongly opposed to applying Once the |
438bfa3
to
7fa9c6a
Compare
The job Click to see the possible cause of the failure (guessed by this bot)
|
I've removed the |
Perhaps! But the solution is definitely not to completely hide them.
Sure, same thing applies here. I don't know anything about how rustdoc's search result ranking works, but it seems reasonable that it could take deprecation status into account. |
@rfcbot merge |
Team member @BurntSushi has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
This PR implements the last step of #68490: marking the
std::u8
etc. modules as fully deprecated and as#[doc(hidden)]
.I did not mark the constants in
std::f32
andstd::f64
as hidden because the module also contains the undeprecatedconsts
submodule.Revival of #107587 (cc @tgross35).
Closes: #68490
r? libs-api