Make missed precondition-free float intrinsics safe #146915
Open
+22
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
rustbot
added
the
T-libs
clarfonthey
commented
Sep 23, 2025
| /// [`f16::abs`](../../std/primitive.f16.html#method.abs) | ||
| #[rustc_nounwind] | ||
| #[rustc_intrinsic] | ||
| pub const unsafe fn fabsf16(x: f16) -> f16; |
There was a problem hiding this comment.
Side remark: fabsf16 and fabsf128 aren't used in their corresponding fn abs definitions, so, I'm assuming they're "not ready yet" in that sense. However, they can still be marked safe for consistency.
jfrimmel
reviewed
Sep 23, 2025
| #[rustc_const_stable(feature = "const_float_methods", since = "1.85.0")] | ||
| #[inline] | ||
| pub const fn abs(self) -> f32 { | ||
| // SAFETY: this is actually a safe intrinsic |
There was a problem hiding this comment.
This comment can/shouls be removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, in my defence, these were both separated out from the other intrinsics in the file and had a different safety comment in the stable versions, so, I didn't notice them before. But, in my offence, the entire reason I did the previous PR was because I was using them for SIMD intrinsic fallbacks, and
fabsis needed for those too, so, I don't really have an excuse.Extra follow-up to #146683.
r? @RalfJung who reviewed the previous one
These don't appear to be used anywhere outside of the standard locations, at least.