Skip to content

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Sep 23, 2025

closes #128887

the errors in that issue are due to two separate issues:

We moved any remaining issues due to MIR inlining into #131960, but keeping #128887 open as well seems unhelpful and confusing.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 23, 2025

r? @jdonszelmann

rustbot has assigned @jdonszelmann.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the stable-nominated Nominated for backporting to the compiler in the stable channel. label Sep 23, 2025
@lcnr
Copy link
Contributor Author

lcnr commented Sep 23, 2025

cc @rust-lang/infra why did rustbot stable nominate this PR 😅

@lcnr lcnr removed the stable-nominated Nominated for backporting to the compiler in the stable channel. label Sep 23, 2025
@samueltardieu
Copy link
Member

Couldn't this be due to #131960 being a regression from stable to stable? However, it is not even mentioned as being closed by this PR.

@lcnr lcnr force-pushed the add-regression-test branch from e298557 to d8369eb Compare September 23, 2025 06:02
@lcnr lcnr force-pushed the add-regression-test branch from d8369eb to 465e373 Compare September 23, 2025 06:02
@theemathas
Copy link
Contributor

It's configured to stable-nominate all T-compiler PRs that close issues that are regressions from stable to stable. https://github.com/rust-lang/rust/blob/master/triagebot.toml#L64-L67

The PR description says "closes #128887"

@lcnr
Copy link
Contributor Author

lcnr commented Sep 23, 2025

Couldn't this be due to #131960 being a regression from stable to stable? However, it is not even mentioned as being closed by this PR.

What exactly do you mean?

#131960 is a regression from stable due to MIR inlining which still exists. We've made it a harder to hit in #129714 but it still triggers for some crates, so we're keeping #131960 open. #128887 also tracked a separately issue which has since been fully fixed in #129073.

It's configured to stable-nominate all T-compiler PRs that close issues that are regressions from stable to stable. https://github.com/rust-lang/rust/blob/master/triagebot.toml#L64-L67

The PR description says "closes #128887"

Ah, that makes a lot of sense, thanks 😅 👍

@theemathas
Copy link
Contributor

theemathas commented Sep 23, 2025

Note: #128887 tracked two different regressions. One of them (triangulate) has been fixed by #129073, and tested in this PR. The other one (one of the geoarrow-rs issues) has already been fixed in #129714 and tested in #129757.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regression: overflow evaluating the requirement
5 participants