-
Notifications
You must be signed in to change notification settings - Fork 13.8k
add regression test #146918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add regression test #146918
Conversation
rustbot has assigned @jdonszelmann. Use |
cc @rust-lang/infra why did |
Couldn't this be due to #131960 being a regression from stable to stable? However, it is not even mentioned as being closed by this PR. |
e298557
to
d8369eb
Compare
d8369eb
to
465e373
Compare
It's configured to stable-nominate all T-compiler PRs that close issues that are regressions from stable to stable. https://github.com/rust-lang/rust/blob/master/triagebot.toml#L64-L67 The PR description says "closes #128887" |
What exactly do you mean? #131960 is a regression from stable due to MIR inlining which still exists. We've made it a harder to hit in #129714 but it still triggers for some crates, so we're keeping #131960 open. #128887 also tracked a separately issue which has since been fully fixed in #129073.
Ah, that makes a lot of sense, thanks 😅 👍 |
closes #128887
the errors in that issue are due to two separate issues:
Mode::Path
#129073)We moved any remaining issues due to MIR inlining into #131960, but keeping #128887 open as well seems unhelpful and confusing.