-
Notifications
You must be signed in to change notification settings - Fork 13.8k
rustdoc-search: use the same ID for entry and path to same item #147045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This decreases the size of the compiler-doc from 57MiB to 56MiB.
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
rustdoc-search: use the same ID for entry and path to same item
self.alias_pointers.push(alias_pointer); | ||
index | ||
} | ||
fn add_entry(&mut self, name: Symbol, entry_data: EntryData, desc: String) -> usize { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth adding a code comment (or a doc comment on the method) to explain a bit what's being done in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I've added a comment.
This comment has been minimized.
This comment has been minimized.
Finished benchmarking commit (8bf899e): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary -0.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.4%, secondary -1.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 470.601s -> 470.924s (0.07%) |
Thanks! @bors r+ |
This decreases the size of the compiler-doc from 57MiB to 56MiB.
r? @GuillaumeGomez