Skip to content

Conversation

nik-rev
Copy link
Contributor

@nik-rev nik-rev commented Sep 28, 2025

new test case in, all 48 keywords in just 300 characters

https://doc.rust-lang.org/reference/keywords.html

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 28, 2025

r? @SparrowLii

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@nik-rev nik-rev changed the title 300 characters, 48 keywords all 48 keywords in just 300 characters (new weird-expr test) Sep 28, 2025
@nik-rev nik-rev changed the title all 48 keywords in just 300 characters (new weird-expr test) all 48 keywords in just 300 characters Sep 28, 2025
@nik-rev
Copy link
Contributor Author

nik-rev commented Sep 28, 2025

Someone suggested me to add it here in this post :)

@jieyouxu jieyouxu assigned jieyouxu and unassigned SparrowLii Sep 28, 2025
@jieyouxu
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 28, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@nik-rev nik-rev force-pushed the keyword-soup branch 2 times, most recently from 2b14966 to 8b8a66a Compare September 28, 2025 01:12
@nik-rev
Copy link
Contributor Author

nik-rev commented Sep 28, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 28, 2025
@nik-rev nik-rev requested a review from jieyouxu September 28, 2025 01:13
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll take this as a "smoke test" that might catch some keyword handling changes.

View changes since this review

@nik-rev
Copy link
Contributor Author

nik-rev commented Sep 28, 2025

@rustbot ready

@Kivooeo
Copy link
Member

Kivooeo commented Sep 28, 2025

As someone who was in favor of this idea, I've given it some thought, and I'm curious if it will be supplemented with new keywords as the language evolves

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 29, 2025

📌 Commit 0d658fe has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2025
bors added a commit that referenced this pull request Sep 29, 2025
Rollup of 7 pull requests

Successful merges:

 - #133477 (Detect tuple structs that are unconstructable due to re-export)
 - #146929 (compiletest: Remove old-output-capture and become a stage0 bootstrap tool)
 - #146979 (constify Default on Nanoseconds)
 - #147092 (Do not compute optimized MIR if code does not type-check.)
 - #147112 (all 48 keywords in just 300 characters)
 - #147122 (Fix some crash-test directives)
 - #147127 (Add a leading dash to linker plugin arguments in the gcc codegen)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f74aa5a into rust-lang:master Sep 29, 2025
10 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 29, 2025
rust-timer added a commit that referenced this pull request Sep 29, 2025
Rollup merge of #147112 - nik-contrib:keyword-soup, r=jieyouxu

all 48 keywords in just 300 characters

new test case in, all 48 keywords in just 300 characters

https://doc.rust-lang.org/reference/keywords.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants