Mention crate being analyzed in query description #147137
Conversation
"running analysis passes on this crate" -> "running analysis passes on crate `foo`" This message is displayed in cycle errors in particular, and in some cases without any spans or any other identifiable information to determine which dependency introduced the cycle.
|
This PR modifies |
rustbot
added
S-waiting-on-review
|
r? @nnethercote rustbot has assigned @nnethercote. Use |
| LL | const FOO: usize = FOO; | ||
| | ^^^ | ||
| = note: ...which again requires simplifying constant for the type system `FOO`, completing the cycle | ||
| = note: cycle used when running analysis passes on this crate |
There was a problem hiding this comment.
Why does is this line removed?
There was a problem hiding this comment.
The rest of the PR looks fine, but this is a worry, because this test looks very similar to the other tests but it is changed in a different way.
| error: aborting due to 1 previous error | ||
|
|
||
| For more information about this error, try `rustc --explain E0391`. | ||
| For more information about this error, try `rustc --explain E0391`. |
There was a problem hiding this comment.
Why is the file-ending newline removed?
There was a problem hiding this comment.
To be perfectly honest: not the faintest idea why my changes affect this test at all 😵
"running analysis passes on this crate" -> "running analysis passes on crate
foo"This message is displayed in cycle errors in particular, and in some cases without any spans or any other identifiable information to determine which dependency introduced the cycle.
Address #74380, but we still need a test for that case in particular.