Skip to content

Conversation

estebank
Copy link
Contributor

error[E0121]: the placeholder `_` is not allowed within types on item signatures for return types
  --> $DIR/in-signature.rs:6:21
   |
LL | fn arr_fn() -> [u8; _] {
   |                     ^ not allowed in type signatures
   |
help: replace with the correct return type
   |
LL - fn arr_fn() -> [u8; _] {
LL + fn arr_fn() -> [u8; 3] {
   |

```
error[E0121]: the placeholder `_` is not allowed within types on item signatures for return types
  --> $DIR/in-signature.rs:6:21
   |
LL | fn arr_fn() -> [u8; _] {
   |                     ^ not allowed in type signatures
   |
help: replace with the correct return type
   |
LL - fn arr_fn() -> [u8; _] {
LL + fn arr_fn() -> [u8; 3] {
   |
```
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 29, 2025

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@fee1-dead
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 30, 2025

📌 Commit eceb485 has been approved by fee1-dead

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 30, 2025
@bors
Copy link
Collaborator

bors commented Sep 30, 2025

⌛ Testing commit eceb485 with merge a2db928...

@bors
Copy link
Collaborator

bors commented Sep 30, 2025

☀️ Test successful - checks-actions
Approved by: fee1-dead
Pushing a2db928 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 30, 2025
@bors bors merged commit a2db928 into rust-lang:master Sep 30, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Sep 30, 2025
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing c5dc558 (parent) -> a2db928 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard a2db9280539229a3b8a084a09886670a57bc7e9c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-gnu-miri: 5165.1s -> 4328.4s (-16.2%)
  2. dist-loongarch64-linux: 6316.2s -> 5294.7s (-16.2%)
  3. x86_64-gnu-llvm-20-2: 6258.0s -> 5436.1s (-13.1%)
  4. i686-gnu-2: 6028.3s -> 5252.2s (-12.9%)
  5. aarch64-msvc-2: 5696.8s -> 4999.9s (-12.2%)
  6. pr-check-2: 2645.4s -> 2323.4s (-12.2%)
  7. x86_64-gnu-llvm-20: 2788.0s -> 2465.2s (-11.6%)
  8. dist-powerpc64-linux: 5236.1s -> 5793.3s (10.6%)
  9. dist-x86_64-msvc-alt: 9106.0s -> 10029.4s (10.1%)
  10. pr-check-1: 1373.6s -> 1510.8s (10.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a2db928): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 468.849s -> 470.437s (0.34%)
Artifact size: 387.70 MiB -> 387.69 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants