Skip to content

Conversation

Walnut356
Copy link
Contributor

This is a less pervasive (but also less powerful) alternative to #144394.

This change only provides benefits to container types on MSVC. The TL;DR is that nodes that don't populate/aren't discoverable in the PDB for various reasons are given an alternate lookup path that generates the nodes by acquiring the base-type via some gross string manipulation and then asking clang for the node it wants (e.g. "ref$<i32>" -> "i32" -> target.FindFirstType("i32").GetPointerType() -> i32 *, which is a valid type for the container to use)

The before/afters are the same as in the above PR's *-msvc LLDB screenshots. This works as a stopgap while the above PR is evaluated, but I think that PR is still a much better solution.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Sep 30, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants