[DebugInfo] Fix container types failing to find template args #147179
+68
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a less pervasive (but also less powerful) alternative to #144394.
This change only provides benefits to container types on MSVC. The TL;DR is that nodes that don't populate/aren't discoverable in the PDB for various reasons are given an alternate lookup path that generates the nodes by acquiring the base-type via some gross string manipulation and then asking clang for the node it wants (e.g.
"ref$<i32>"
->"i32"
->target.FindFirstType("i32").GetPointerType()
->i32 *
, which is a valid type for the container to use)The before/afters are the same as in the above PR's
*-msvc
LLDB screenshots. This works as a stopgap while the above PR is evaluated, but I think that PR is still a much better solution.