std: sys::net cleanups
#147190
Open
std: sys::net cleanups
#147190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
O-unix
|
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
|
r? libs |
hkBst
reviewed
Oct 1, 2025
| let mut len = size_of_val(&storage) as c::socklen_t; | ||
| let mut storage = MaybeUninit::<c::sockaddr_storage>::uninit(); | ||
| let mut len = size_of::<c::sockaddr_storage>() as c::socklen_t; | ||
| let sock = self.inner.accept(storage.as_mut_ptr() as *mut _, &mut len)?; |
There was a problem hiding this comment.
perhaps add let storage = storage.assume_init() here?
hkBst
reviewed
Oct 1, 2025
| } | ||
|
|
||
| pub fn new_raw(fam: i32, ty: i32) -> io::Result<Socket> { | ||
| pub fn new(fam: i32, ty: i32) -> io::Result<Socket> { |
There was a problem hiding this comment.
The other impls seem to use c_int instead of i32 for these parameters.
There was a problem hiding this comment.
hermit_abi uses i32 for socket, so it's probably best to use it here as well.
hkBst
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains three improvements to the socket-based networking implementation (aa1263e is just to add the now missing
unsafe). Best reviewed commit-by-commit.