-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Test: Ambigious bindings in same namespace with the same res #147196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Test: Ambigious bindings in same namespace with the same res #147196
Conversation
I mostly wanted a version of the same issue that fails on nightly, but having both would be even better. |
Added a revision that uses the version where the glob import is inserted by a macro. I have confirmed this fails when using |
This comment has been minimized.
This comment has been minimized.
@rustbot ready I'm still confused why the |
This comment has been minimized.
This comment has been minimized.
Reminder, once the PR becomes ready for a review, use |
Default edition may be different in ui tests (2015) and your local setup, it affects import resolution. |
99de60b
to
0b84290
Compare
Ah, right, editions. I set them up correctly based on the output I get on my local setup with The only difference I see is that @rustbot ready |
This comment has been minimized.
This comment has been minimized.
This version is even better, the issue can be seen more directly.
This is not important. r=me with green CI (stderr files need to be updated) and after squashing commits. |
ffb7027
to
a7eed08
Compare
Nice!
You'll have to r+ this :), I don't have those privileges. @rustbot ready |
Add a test based on the discussion here and related to #145575 (comment).
This is the most reduced form I could create that passes on nightly but fails with #145108 (see #gsoc > Project: Parallel Macro Expansion @ 💬).
Also not sure about the test names.
r? @petrochenkov